Rebase to master and add github workflow

Author: vepadulano

.github/workflows/python_wheel_build.yml

@@ -0,0 +1,54 @@
+name: 'ROOT Python wheels'
+
+on:
+  workflow_dispatch:
+    inputs:
+      branch:
+        description: 'The branch for which the Python wheel has to be generated'
+        type: string
+        required: true
+        default: "experimental-pip-install-root"
+
+jobs:
+  python_wheel:
+    runs-on: ubuntu-latest
+    env:
+      WORKDIR: /home/runner/work/root
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ inputs.branch }}
+
+      - name: Install Kerberos utilities
+        run: sudo apt-get install -y krb5-user
+
+      - name: Install XRootD client
+        run: sudo apt-get -y install xrootd-client
+
+      - name: Build wheels
+        uses: pypa/cibuildwheel@v3.0.1
+      
+      # Upload artifact to github
+      - uses: actions/upload-artifact@v4
+        with:
+          name: cibw-wheels-test
+          path: ./wheelhouse/*.whl
+
+      - name: Upload wheel to EOS
+        env:
+          RWEBEOS_KT: ${{ secrets.RWEBEOS_KT }}
+          KT_FILE_NAME: /tmp/decoded.keytab
+          EOS_PATH: /eos/project/r/root-eos/www/experimental-python-wheels
+          EOS_ENDPOINT: root://eosproject-r.cern.ch
+          KRB5CCNAME: /tmp/krb5cc
+        working-directory: ${{ env.WORKDIR }}
+        run: |
+          echo +++ Content
+          ls
+          echo +++ Retrieving the secret
+          echo ${RWEBEOS_KT} | base64 -d > ${KT_FILE_NAME}
+          echo +++ Creating the token
+          kinit  -p ${{ secrets.KRB5USER }}@${{ secrets.KRB5REALM }} -kt ${KT_FILE_NAME}
+          echo +++ Running the copy
+          xrdcp -rf wheelhouse ${EOS_ENDPOINT}/${EOS_PATH}/

bindings/pyroot/pythonizations/CMakeLists.txt

@@ -168,25 +168,13 @@ file(COPY ${ROOT_headers_dir}/ DESTINATION ${CMAKE_BINARY_DIR}/include/ROOT)
 set(libname ROOTPythonizations)
 
 add_library(${libname} SHARED ${cpp_sources})
-# It is crucial to add the path to the other ROOT libraries for compatibility with pip build backends.
-# After the `pip install` step, the target install user directory will look like:
-# site-packages/
-# -- cppyy/
-# -- cppyy_backend/
-# -- libcppyy.so
-# -- libcppyy_backend.so
-# -- libROOTPythonizations.so
-# -- ROOT/
-# With most of the ROOT libraries being stored in `ROOT/lib`. The RPATH must then be updated for the CPython extension
-# shared libraries.
-set_target_properties(${libname} PROPERTIES  INSTALL_RPATH "${CMAKE_INSTALL_RPATH}:$ORIGIN/ROOT/lib")
 
 # Insert the ROOTPythonizationsPySources in the dependency graph
 add_dependencies(${libname} ROOTPythonizationsPySources)
 
 # Set the suffix to '.so' and the prefix to 'lib'
 set_target_properties(${libname} PROPERTIES ${ROOT_LIBRARY_PROPERTIES_NO_VERSION})
-target_link_libraries(${libname} PUBLIC Core Tree cppyy)
+target_link_libraries(${libname} PUBLIC ROOT::Core ROOT::Tree cppyy)
 if(MSVC)
   set_target_properties(${libname} PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS TRUE)
   set_target_properties(${libname} PROPERTIES SUFFIX ".pyd")
@@ -240,6 +228,18 @@ else()
       LIBRARY_OUTPUT_DIRECTORY ${pymoduledir_build})
 endif()
 
+# It is crucial to add the path to the other ROOT libraries for compatibility with pip build backends.
+# After the `pip install` step, the target install user directory will look like:
+# site-packages/
+# -- cppyy/
+# -- cppyy_backend/
+# -- libcppyy.so
+# -- libcppyy_backend.so
+# -- ROOT/
+# -- -- libROOTPythonizations.so
+# With most of the ROOT libraries being stored in `ROOT/lib`. The RPATH must then be updated for the CPython extension
+# shared libraries.
+
 if(NOT MSVC)
   # Make sure that relative RUNPATH to main ROOT libraries is always correct.
 
@@ -254,7 +254,8 @@ if(NOT MSVC)
   else()
     set_target_properties(${libname} PROPERTIES
         BUILD_RPATH "$ORIGIN/${pymoduledir_to_libdir_build}"
-        INSTALL_RPATH "$ORIGIN/${pymoduledir_to_libdir_install}"
+        # ATTENTION: NEXT PART IS CRUCIAL SEE COMMENT ABOVE
+        INSTALL_RPATH "$ORIGIN/${pymoduledir_to_libdir_install}:${CMAKE_INSTALL_RPATH}:$ORIGIN/lib"
     )
   endif()
 

pyproject.toml

@@ -3,7 +3,7 @@ requires = ["cmake", "setuptools<72", "wheel", "ninja", "numpy"]
 
 [project]
 name = "ROOT"
-version = "0.1a6"
+version = "0.1a7"
 
 requires-python = ">=3.8"
 authors = [
@@ -22,9 +22,10 @@ root = "ROOT._rootcli:main"
 [tool.cibuildwheel]
 # Increase pip debugging output
 build-verbosity = 1
-build="cp3{8,9,10,11,12,13}-manylinux_x86_64"
+#build="cp3{8,9,10,11,12,13}-manylinux_x86_64"
+build="cp313-manylinux_x86_64"
 manylinux-x86_64-image = "manylinux_2_28"
 
 # Install system libraries
 [tool.cibuildwheel.linux]
-before-all = "dnf install -y epel-release && /usr/bin/crb enable && dnf install -y openssl-devel libX11-devel libXpm-devel libXft-devel libXext-devel libuuid-devel"
+before-all = "dnf install -y epel-release && /usr/bin/crb enable && dnf install -y openssl-devel libX11-devel libXpm-devel libXft-devel libXext-devel libuuid-devel libjpeg-devel giflib-devel"

setup.py

@@ -11,8 +11,8 @@
 -- cppyy_backend/
 -- libcppyy.so
 -- libcppyy_backend.so
--- libROOTPythonizations.so
 -- ROOT/
+-- -- libROOTPythonizations.so
 ```
 
 A custom extension module is injected in the setuptools setup to properly
@@ -42,17 +42,18 @@ def run(self):
         _build.run(self)
 
         # Configure ROOT build
-        base_opts = shlex.split("cmake -GNinja")
+        base_opts = shlex.split("cmake -GNinja -Dccache=ON")
         mode_opts = shlex.split(
             "-Dbuiltin_nlohmannjson=ON -Dbuiltin_tbb=ON -Dbuiltin_xrootd=ON "  # builtins
             "-Dbuiltin_lz4=ON -Dbuiltin_lzma=ON -Dbuiltin_zstd=ON -Dbuiltin_xxhash=ON"  # builtins
             "-Druntime_cxxmodules=ON -Drpath=ON -Dfail-on-missing=ON "  # Generic build configuration
             "-Dgminimal=ON -Dasimage=ON -Dopengl=OFF "  # Graphics
-            "-Dpyroot=ON -Ddataframe=ON -Dxrootd=ON -Dimt=ON "
-            "-Droofit=ON")
-        dirs_opts = shlex.split(
-            f"-DCMAKE_INSTALL_PREFIX={INSTALL_DIR} -B {BUILD_DIR} -S {SOURCE_DIR}")
+            "-Dpyroot=ON -Ddataframe=ON -Dxrootd=ON -Dssl=ON -Dimt=ON "
+            "-Droofit=ON"
+        )
+        dirs_opts = shlex.split(f"-DCMAKE_INSTALL_PREFIX={INSTALL_DIR} -B {BUILD_DIR} -S {SOURCE_DIR}")
         configure_command = base_opts + mode_opts + dirs_opts
+        print(f"\n\n{' '.join(configure_command)}\n\n")
         subprocess.run(configure_command, check=True)
 
         # Run build with CMake
@@ -62,7 +63,7 @@ def run(self):
 
 class ROOTInstall(_install):
     def _get_install_path(self):
-        if hasattr(self, 'bdist_dir') and self.bdist_dir:
+        if hasattr(self, "bdist_dir") and self.bdist_dir:
             install_path = self.bdist_dir
         else:
             install_path = self.install_lib
@@ -83,16 +84,13 @@ def run(self):
         self.copy_tree(INSTALL_DIR, os.path.join(install_path, "ROOT"))
 
         # Copy cppyy packages separately
-        self.copy_tree(os.path.join(lib_dir, "cppyy"),
-                       os.path.join(install_path, "cppyy"))
-        self.copy_tree(os.path.join(lib_dir, "cppyy_backend"),
-                       os.path.join(install_path, "cppyy_backend"))
+        self.copy_tree(os.path.join(lib_dir, "cppyy"), os.path.join(install_path, "cppyy"))
+        self.copy_tree(os.path.join(lib_dir, "cppyy_backend"), os.path.join(install_path, "cppyy_backend"))
 
         # Finally copy CPython extension libraries
-        extlibs = ["libcppyy.so", "libcppyy_backend.so",
-                   "libROOTPythonizations.so"]
-        for ext in extlibs:
-            self.copy_file(os.path.join(lib_dir, ext), install_path)
+        self.copy_file(os.path.join(lib_dir, "libcppyy.so"), install_path)
+        self.copy_file(os.path.join(lib_dir, "libcppyy_backend.so"), install_path)
+        self.copy_file(os.path.join(lib_dir, "ROOT", "libROOTPythonizations.so"), os.path.join(install_path, "ROOT"))
 
     def get_outputs(self):
         outputs = _install.get_outputs(self)
@@ -103,31 +101,28 @@ class DummyExtension(Extension):
     """
     Dummy CPython extension for setuptools setup.
 
-    In order to generate the wheel with CPython extension metadata (i.e. 
+    In order to generate the wheel with CPython extension metadata (i.e.
     producing one wheel per supported Python version), setuptools requires that
     at least one CPython extension is declared in the `ext_modules` kwarg passed
     to the `setup` function. Usually, declaring a CPython extension triggers
     compilation of the corresponding sources, but in this case we already do
     that in the CMake build step. This class defines a dummy extension that
     can be declared to setuptools while avoiding any further compilation step.
     """
+
     def __init__(_):
         super().__init__(name="Dummy", sources=[])
 
 
-pkgs = (
-    find_packages('bindings/pyroot/pythonizations/python') +
-    find_packages('bindings/pyroot/cppyy/cppyy/python', include=['cppyy'])
+pkgs = find_packages("bindings/pyroot/pythonizations/python") + find_packages(
+    "bindings/pyroot/cppyy/cppyy/python", include=["cppyy"]
 )
 
 s = setup(
     long_description=LONG_DESCRIPTION,
-    package_dir={'': 'bindings/pyroot/pythonizations/python',
-                 'cppyy': 'bindings/pyroot/cppyy/cppyy/python'},
+    package_dir={"": "bindings/pyroot/pythonizations/python", "cppyy": "bindings/pyroot/cppyy/cppyy/python"},
     packages=pkgs,
     # Crucial to signal this is not a pure Python package
     ext_modules=[DummyExtension()],
-    cmdclass={
-        'build': ROOTBuild,
-        'install': ROOTInstall},
+    cmdclass={"build": ROOTBuild, "install": ROOTInstall},
 )