Skip to content

Commit 507d5b5

Browse files
committed
[roottest] disable some root/tree/reader tests on windows
Getting linker failure when trying to compile hardTreeReaderTest.cpp macro. ``` hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl B::Class(void)" (?Class@B@@SAPEAVTClass@@xz) referenced in function "public: class TBranch * __cdecl TTree::Branch<class B>(char const *,class B * *,int,int)" (??$Branch@VB@@@ttree@@QEAAPEAVTBranch@@PEBDPEAPEAVB@@hh@Z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl B::Streamer(class TBuffer &)" (?Streamer@B@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl A::Class(void)" (?Class@A@@SAPEAVTClass@@xz) referenced in function "public: virtual class TClass * __cdecl A::IsA(void)const " (?IsA@A@@UEBAPEAVTClass@@xz) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl A::Streamer(class TBuffer &)" (?Streamer@A@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] C:\ROOT-CI\build\roottest\root\tree\reader\hardTreeReaderTest_cpp.dll : fatal error LNK1120: 4 unresolved externals [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] ```
1 parent 8425de1 commit 507d5b5

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

roottest/root/tree/reader/CMakeLists.txt

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,19 @@ ROOTTEST_ADD_TEST(VectorBranches
3737
MACRO execVectorBranches.C
3838
OUTREF execVectorBranches.ref)
3939

40-
ROOTTEST_COMPILE_MACRO(A.h
41-
FIXTURES_SETUP root-tree-reader-A-fixture)
42-
43-
ROOTTEST_COMPILE_MACRO(hardTreeReaderTest.cpp
44-
FIXTURES_REQUIRED root-tree-reader-A-fixture
45-
FIXTURES_SETUP root-tree-reader-hardTreeReaderTest-fixture)
46-
47-
ROOTTEST_ADD_TEST(complexTree
48-
MACRO runcomplexTree.C
49-
OUTREF complexTree.ref
50-
FIXTURES_REQUIRED root-tree-reader-A-fixture root-tree-reader-hardTreeReaderTest-fixture)
40+
if(NOT MSVC OR win_broken_tests)
41+
ROOTTEST_COMPILE_MACRO(A.h
42+
FIXTURES_SETUP root-tree-reader-A-fixture)
43+
44+
ROOTTEST_COMPILE_MACRO(hardTreeReaderTest.cpp
45+
FIXTURES_REQUIRED root-tree-reader-A-fixture
46+
FIXTURES_SETUP root-tree-reader-hardTreeReaderTest-fixture)
47+
48+
ROOTTEST_ADD_TEST(complexTree
49+
MACRO runcomplexTree.C
50+
OUTREF complexTree.ref
51+
FIXTURES_REQUIRED root-tree-reader-A-fixture root-tree-reader-hardTreeReaderTest-fixture)
52+
endif()
5153

5254
# IntroTut tests fails while file eventdata.root is missing on eos
5355
# ROOTTEST_ADD_TEST(assertIntroTut

0 commit comments

Comments
 (0)