[RF] Optimize RooProduct codegen

guitargeek · guitargeek · commit 5d22f2424926 · 2025-11-13T13:36:51.000+01:00
diff --git a/roofit/codegen/src/CodegenImpl.cxx b/roofit/codegen/src/CodegenImpl.cxx
@@ -557,7 +557,14 @@ void codegenImpl(RooPolynomial &arg, CodegenContext &ctx)
 
 void codegenImpl(RooProduct &arg, CodegenContext &ctx)
 {
-   ctx.addResult(&arg, ctx.buildCall(mathFunc("product"), arg.realComponents(), arg.realComponents().size()));
+   std::stringstream ss;
+   std::size_t n = arg.realComponents().size();
+   for (std::size_t i = 0; i < n; ++i) {
+      ss << ctx.getResult(arg.realComponents()[i]);
+      if (i != n - 1)
+         ss << " * " << std::endl;
+   }
+   ctx.addResult(&arg, ss.str());
 }
 
 void codegenImpl(RooRatio &arg, CodegenContext &ctx)

Original file line number	Diff line number	Diff line change
`@@ -557,7 +557,14 @@ void codegenImpl(RooPolynomial &arg, CodegenContext &ctx)`
`557`	`557`
`558`	`558`	`void codegenImpl(RooProduct &arg, CodegenContext &ctx)`
`559`	`559`	`{`
`560`		`- ctx.addResult(&arg, ctx.buildCall(mathFunc("product"), arg.realComponents(), arg.realComponents().size()));`
	`560`	`+ std::stringstream ss;`
	`561`	`+ std::size_t n = arg.realComponents().size();`
	`562`	`+ for (std::size_t i = 0; i < n; ++i) {`
	`563`	`+ ss << ctx.getResult(arg.realComponents()[i]);`
	`564`	`+ if (i != n - 1)`
	`565`	`+ ss << " * " << std::endl;`
	`566`	`+ }`
	`567`	`+ ctx.addResult(&arg, ss.str());`
`561`	`568`	`}`
`562`	`569`
`563`	`570`	`void codegenImpl(RooRatio &arg, CodegenContext &ctx)`