Skip to content

Commit 69e36d2

Browse files
committed
[net] Add comment about testParallelMergingFile's mutexes
1 parent 1bc24ba commit 69e36d2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

net/net/test/testParallelMergingFile.cxx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ static void Server(std::unique_ptr<TServerSocket> ss, const std::string &outFile
6868
msg->ReadLong64(length);
6969

7070
// XXX: this lock is here to work around https://github.com/root-project/root/issues/20641
71+
// Note that we don't care about minimizing its scope since we are not testing multithreaded scaling here
72+
// and it's fine if the client's and server's operations get serialized by the mutexes.
7173
std::scoped_lock<std::mutex> lock(gMutex);
7274
auto input = std::make_unique<TMemFile>((std::string("server_") + filename), msg->Buffer() + msg->Length(),
7375
length, "READ");

0 commit comments

Comments
 (0)