move the tests to the ubuntu runner

Author: siliataider

.github/workflows/cibuildwheel-impl/action.yml

@@ -8,20 +8,10 @@ inputs:
 runs:
   using: "composite"
   steps:
-    - name: Install system dependencies
-      shell: bash
-      run: |
-        sudo apt install -y binutils cmake dpkg-dev g++ gcc libssl-dev git libx11-dev \
-        libxext-dev libxft-dev libxpm-dev libtbb-dev libvdt-dev libgif-dev libfftw3-dev
-
     - name: Build wheel
       uses: pypa/cibuildwheel@v3.0.1
       env:
-        PIP_NO_CACHE_DIR: "1"
         CIBW_BUILD: ${{ inputs.build-tag }}
-        CIBW_TEST_REQUIRES: "-r test_tutorials/requirements.txt"
-        CIBW_TEST_SOURCES: "test_tutorials"
-        CIBW_TEST_COMMAND: "pytest -vv -rF --show-capture=all test_tutorials"
 
     - name: Upload wheel
       uses: actions/upload-artifact@v4

.github/workflows/python_wheel_build.yml

@@ -35,6 +35,48 @@ jobs:
         with:
           build-tag: ${{ matrix.target }}
 
+  test-tutorials:
+    needs: build-wheels
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install required system packages
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y libfftw3-dev
+
+      - name: Download produced wheels
+        uses: actions/download-artifact@v4
+        with:
+          path: wheels
+          merge-multiple: true
+
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Install produced wheel
+        run: |
+          ls -R wheels
+          PY_VER=$(python -c "import sys; print(f'cp{sys.version_info.major}{sys.version_info.minor}')")
+          WHEEL=$(ls wheels/*${PY_VER}*.whl | head -n 1)
+          echo "Python version: ${PY_VER}, installing wheel: ${WHEEL}"
+          pip install "$WHEEL"
+
+      - name: Install tutorials dependencies
+        run: |
+          python -m pip install -r test_tutorials/requirements.txt
+
+      - name: Run tutorials
+        run: |
+          pytest -vv -rF --show-capture=all test_tutorials
+
   create-and-upload-wheel-registry:
       if: github.event_name != 'pull_request' # The secrets are not available in PR
       needs: build-wheels

test_tutorials/requirements.txt

@@ -1,49 +1,19 @@
-# ROOT requirements for third-party Python packages
+# ROOT requirements for third-party Python packages used to run tutorials
 
 # PyROOT: Interoperability with numpy arrays
 numpy
 pandas
 
-# TMVA: SOFIE
-# dm-sonnet # used for GNNs
-# graph_nets
-# onnx
-
-# TMVA: PyMVA interfaces
-# scikit-learn
-# tensorflow ; python_version < "3.13" # TensorFlow doesn't support Python 3.13 yet
-# torch
-# xgboost
-
 # PyROOT: ROOT.Numba.Declare decorator
 numba>=0.48
 cffi>=1.9.1
 
-# Notebooks: ROOT C++ kernel
-# IPython
-# jupyter
-# metakernel>=0.20.0
-# notebook>=4.4.1
-
-# Distributed RDataFrame
-# pyspark>=2.4 # Spark backend
-# dask>=2022.08.1 # Dask backend
-# distributed>=2022.08.1 # Dask backend
-
-# JsMVA: Jupyter notebook magic for TMVA
-# ipywidgets
-
 # Unified Histogram Interface (UHI)
 uhi
 matplotlib
 mplhep
 
-# For testing
-# nbconvert>=7.4.0
+# Other
 pytest
-# setuptools
-
 scikit-learn
-
-# Look for CPU-only versions of PyTorch to avoid pulling CUDA in the CI docker images.
-# -f https://download.pytorch.org/whl/cpu/torch_stable.html
+xgboost

test_tutorials/test_tutorials.py

@@ -1,39 +1,44 @@
+import os
+import pathlib
+import signal
 import subprocess
 import sys
-import pathlib
-import ROOT
-import os
+
 import pytest
-import signal
+import ROOT
 
 ROOT.gROOT.SetBatch(True)
 
 tutorial_dir = pathlib.Path(str(ROOT.gROOT.GetTutorialDir()))
 
-subdirs = [
-    "analysis/dataframe",
-    "analysis/tree",
-    "hist",
-    "io/ntuple",
-    "roofit/roofit"
-]
+subdirs = ["analysis/dataframe", "analysis/tree", "hist", "io/ntuple", "roofit/roofit"]
+
+SKIP_TUTORIALS = {
+    "rf503_wspaceread.py",
+    "rf615_simulation_based_inference.py",
+    "ntpl004_dimuon.C",
+    "ntpl008_import.C",
+    # skip distributed RDataFrame tutorials for now
+    "distrdf",
+}
 
 # ----------------------
 # Python tutorials tests
 # ----------------------
 py_tutorials = []
 for sub in subdirs:
     sub_path = tutorial_dir / sub
-    # py_tutorials.extend(sub_path.rglob("*.py"))
     for f in sub_path.rglob("*.py"):
-        # skip distrdf tutorials for now
-        if "distrdf" in f.name:
+        if any(skip in f.name for skip in SKIP_TUTORIALS):
+            print("Skipping Python tutorial:", f)
             continue
         py_tutorials.append(f)
 
+
 def test_tutorials_are_detected():
     assert len(py_tutorials) > 0
 
+
 @pytest.mark.parametrize("tutorial", py_tutorials, ids=lambda p: p.name)
 def test_tutorial(tutorial):
     env = dict(**os.environ)
@@ -46,6 +51,8 @@ def test_tutorial(tutorial):
             check=True,
             env=env,
             timeout=60,
+            capture_output=True,
+            text=True,
         )
         print("Test stderr:", result.stderr)
     except subprocess.TimeoutExpired:
@@ -56,17 +63,24 @@ def test_tutorial(tutorial):
             pytest.skip(f"Skipping {tutorial.name} (requires user input)")
         raise
 
+
 # ----------------------
 # C++ tutorials tests
 # ----------------------
 cpp_tutorials = []
 for sub in subdirs:
     sub_path = tutorial_dir / sub
-    cpp_tutorials.extend(sub_path.rglob("*.C"))
+    for f in sub_path.rglob("*.C"):
+        if any(skip in f.name for skip in SKIP_TUTORIALS):
+            print("Skipping C++ tutorial:", f)
+            continue
+        cpp_tutorials.append(f)
+
 
 def test_cpp_tutorials_are_detected():
     assert len(cpp_tutorials) > 0
 
+
 @pytest.mark.parametrize("tutorial", cpp_tutorials, ids=lambda p: p.name)
 def test_cpp_tutorial(tutorial):
     try:
@@ -75,13 +89,14 @@ def test_cpp_tutorial(tutorial):
             check=True,
             timeout=60,
             capture_output=True,
-            text=True
+            text=True,
         )
+        print("Test stderr:", result.stderr)
     except subprocess.TimeoutExpired:
         pytest.skip(f"Tutorial {tutorial} timed out")
     except subprocess.CalledProcessError as e:
         if e.returncode == -signal.SIGILL or e.returncode == 132:
             pytest.fail(f"Failing {tutorial.name} (illegal instruction on this platform)")
         elif "EOFError" in e.stderr:
             pytest.skip(f"Skipping {tutorial.name} (requires user input)")
-        raise
+        raise