Skip to content

Commit 7cad46e

Browse files
committed
[hist] Test missed check in GetNormalRange
1 parent e928d42 commit 7cad46e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

hist/histv7/test/hist_regular.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ TEST(RRegularAxis, GetNormalRange)
171171
static constexpr std::size_t Bins = 20;
172172
const RRegularAxis axis(Bins, 0, Bins);
173173
const auto index0 = RBinIndex(0);
174+
const auto index1 = RBinIndex(1);
174175
const auto indexBins = RBinIndex(Bins);
175176

176177
{
@@ -188,7 +189,6 @@ TEST(RRegularAxis, GetNormalRange)
188189
}
189190

190191
{
191-
const auto index1 = RBinIndex(1);
192192
const auto index5 = RBinIndex(5);
193193
const auto normal = axis.GetNormalRange(index1, index5);
194194
EXPECT_EQ(normal.GetBegin(), index1);
@@ -197,7 +197,6 @@ TEST(RRegularAxis, GetNormalRange)
197197
}
198198

199199
{
200-
const auto index1 = RBinIndex(1);
201200
const auto empty = axis.GetNormalRange(index1, index1);
202201
EXPECT_EQ(empty.GetBegin(), index1);
203202
EXPECT_EQ(empty.GetEnd(), index1);
@@ -211,6 +210,7 @@ TEST(RRegularAxis, GetNormalRange)
211210
EXPECT_THROW(axis.GetNormalRange(indexBins, indexBins), std::invalid_argument);
212211
EXPECT_THROW(axis.GetNormalRange(index0, overflow), std::invalid_argument);
213212
EXPECT_THROW(axis.GetNormalRange(index0, indexBins + 1), std::invalid_argument);
213+
EXPECT_THROW(axis.GetNormalRange(index1, index0), std::invalid_argument);
214214
}
215215

216216
TEST(RRegularAxis, GetFullRange)

hist/histv7/test/hist_variable.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ TEST(RVariableBinAxis, GetNormalRange)
208208

209209
const RVariableBinAxis axis(bins);
210210
const auto index0 = RBinIndex(0);
211+
const auto index1 = RBinIndex(1);
211212
const auto indexBins = RBinIndex(Bins);
212213

213214
{
@@ -225,7 +226,6 @@ TEST(RVariableBinAxis, GetNormalRange)
225226
}
226227

227228
{
228-
const auto index1 = RBinIndex(1);
229229
const auto index5 = RBinIndex(5);
230230
const auto normal = axis.GetNormalRange(index1, index5);
231231
EXPECT_EQ(normal.GetBegin(), index1);
@@ -234,7 +234,6 @@ TEST(RVariableBinAxis, GetNormalRange)
234234
}
235235

236236
{
237-
const auto index1 = RBinIndex(1);
238237
const auto empty = axis.GetNormalRange(index1, index1);
239238
EXPECT_EQ(empty.GetBegin(), index1);
240239
EXPECT_EQ(empty.GetEnd(), index1);
@@ -248,6 +247,7 @@ TEST(RVariableBinAxis, GetNormalRange)
248247
EXPECT_THROW(axis.GetNormalRange(indexBins, indexBins), std::invalid_argument);
249248
EXPECT_THROW(axis.GetNormalRange(index0, overflow), std::invalid_argument);
250249
EXPECT_THROW(axis.GetNormalRange(index0, indexBins + 1), std::invalid_argument);
250+
EXPECT_THROW(axis.GetNormalRange(index1, index0), std::invalid_argument);
251251
}
252252

253253
TEST(RVariableBinAxis, GetFullRange)

0 commit comments

Comments
 (0)