Skip to content

Commit 962d075

Browse files
committed
roottest: root-tree-branch avoid output name clash.
Both roottest-root-tree-branches-abc_rflex and roottest-root-tree-branches-abc_rflx-libgen-build were producing the file roottest/root/tree/branches/abc_rflx_rdict.pcm leading to a race condition leading to failure such as: ``` --- /github/home/ROOT-CI/src/roottest/root/tree/branches/abc.ref Wed Aug 20 09:27:06 2025 +++ /github/home/ROOT-CI/build/roottest/root/tree/branches/abc-cint-reflex-read.log Wed Aug 20 10:49:39 2025 @@ -1,4 +1,6 @@ +Error in <TFile::ReadBuffer>: error reading all requested bytes from file /github/home/ROOT-CI/build/roottest/root/tree/branches/abc_rflx_rdict.pcm, got 63 of 300 +Error in <TFile::Init>: /github/home/ROOT-CI/build/roottest/root/tree/branches/abc_rflx_rdict.pcm failed to read the file type data. 20: read d.abc==20, d.derived==19 40: read d.abc==40, d.derived==39 60: read d.abc==60, d.derived==59 ``` Side note: the generated dictionary files were not clashing by 'happenstance' with one named `abc_rflx.cpp` and the other named `abc_rflx.cxx`.
1 parent c34d1d6 commit 962d075

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

roottest/root/tree/branches/CMakeLists.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22
ROOTTEST_ADD_TEST(initOffset
33
MACRO initOffset.C+)
44

5-
ROOTTEST_ADD_TEST(abc_rflx
6-
COMMAND ${ROOT_genreflex_CMD} ${CMAKE_CURRENT_SOURCE_DIR}/abc.h -o abc_rflx.cpp
7-
FIXTURES_SETUP root-tree-branches-abc-rflx-dict-fixture)
5+
ROOTTEST_ADD_TEST(abc_rflx_gen_dict
6+
COMMAND ${ROOT_genreflex_CMD} ${CMAKE_CURRENT_SOURCE_DIR}/abc.h -o standalone_abc_rflx.cpp)
87

98
ROOTTEST_COMPILE_MACRO(abc.h
109
FIXTURES_SETUP root-tree-branches-abc-fixture)

0 commit comments

Comments
 (0)