[RF] Remove all RooDirItem::appendToDir calls.

In view of ROOT 7, I studied the effects of RooDirItem-derived classes.
Since at least 5 years, RooDataHist, RooDataSet and RooFitResult were
calling RooDirItem::appendToDir(this, true). This has no effect, since
forceMemoryResident==true.
Here, all these calls that don't have any effect are removed to make
more obvious that no automatic registration is happening.

Author: hageboeck

roofit/roofitcore/src/RooDataHist.cxx

@@ -124,7 +124,6 @@ RooDataHist::RooDataHist(RooStringView name, RooStringView title, const RooArgSe
 
   registerWeightArraysToDataStore();
 
-  appendToDir(this,true) ;
   TRACE_CREATE;
 }
 
@@ -355,8 +354,6 @@ RooDataHist::RooDataHist(RooStringView name, RooStringView title, const RooArgLi
 
     // Initialize empty
     initialize() ;
-    appendToDir(this,true) ;
-
   }
 
   registerWeightArraysToDataStore();
@@ -378,7 +375,6 @@ void RooDataHist::importTH1(const RooArgList& vars, const TH1& histo, double wgt
 
   // Initialize internal data structure
   initialize() ;
-  appendToDir(this,true) ;
 
   // Define x,y,z as 1st, 2nd and 3rd observable
   RooRealVar* xvar = static_cast<RooRealVar*>(_vars.find(vars.at(0)->GetName())) ;
@@ -534,7 +530,6 @@ void RooDataHist::importTH1Set(const RooArgList& vars, RooCategory& indexCat, st
   // Initialize internal data structure
   if (!init) {
     initialize() ;
-    appendToDir(this,true) ;
     init = true ;
   }
 
@@ -644,7 +639,6 @@ void RooDataHist::importDHistSet(const RooArgList & /*vars*/, RooCategory &index
    }
 
    initialize();
-   appendToDir(this, true);
 
    for (const auto &diter : dmap) {
       std::string const &label = diter.first;
@@ -904,8 +898,6 @@ RooDataHist::RooDataHist(const RooDataHist& other, const char* newname) :
   }
 
   registerWeightArraysToDataStore();
-
- appendToDir(this,true) ;
 }
 
 

roofit/roofitcore/src/RooDataSet.cxx

@@ -374,8 +374,6 @@ RooDataSet::RooDataSet(RooStringView name, RooStringView title, const RooArgSet&
       }
     }
 
-    appendToDir(this,true) ;
-
     // Initialize RooDataSet with optional weight variable
     initialize(nullptr) ;
 
@@ -450,8 +448,6 @@ RooDataSet::RooDataSet(RooStringView name, RooStringView title, const RooArgSet&
       }
     }
 
-    appendToDir(this,true) ;
-
     // Initialize RooDataSet with optional weight variable
     initialize(wgtVarName);
 
@@ -523,7 +519,6 @@ RooDataSet::RooDataSet(RooStringView name, RooStringView title, const RooArgSet&
 RooDataSet::RooDataSet(RooDataSet const & other, const char* newname) :
   RooAbsData(other,newname), RooDirItem()
 {
-  appendToDir(this,true) ;
   initialize(other._wgtVar?other._wgtVar->GetName():nullptr);
   TRACE_CREATE;
 }

roofit/roofitcore/src/RooFitResult.cxx

@@ -63,8 +63,6 @@ using std::ostream, std::string, std::pair, std::vector, std::setw;
 
 RooFitResult::RooFitResult(const char *name, const char *title) : TNamed(name, title)
 {
-   if (name)
-      appendToDir(this, true);
 }
 
 
@@ -100,9 +98,6 @@ RooFitResult::RooFitResult(const RooFitResult &other)
   if (other._VM) _VM = new TMatrixDSym(*other._VM) ;
   if (other._CM) _CM = new TMatrixDSym(*other._CM) ;
   if (other._GC) _GC = new TVectorD(*other._GC) ;
-
-  if (GetName())
-    appendToDir(this, true);
 }