Skip to content

Commit c84322f

Browse files
committed
[ci] Keep one build with check_connection=ON
Since `check_connection=ON` is the default from ROOT builds from source, it is important to test this in the CI. But we don't want to test this in general, because of the constant risk that the probe file on `root.cern` can't be downloaded. So we should test it on a platform that uses builtins that trigger the connection check, and where sporadic build failues annoy us the least. The platforms that use lots of builtins and will therefore trigger the connection check forever are `windows` and `macos`. We don't have many Windows CI configs, so we should not risk one of them. Therefore, I suggest to use some `mac` platform. Let's use `mac-beta`, so the sole config with `check_connection=ON` will not be dropped without replacement in the future.
1 parent 2f2a29b commit c84322f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/root-ci-config/buildconfig/mac-beta.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ builtin_xrootd=ON
2222
builtin_xxhash=ON
2323
builtin_zeromq=ON
2424
builtin_zstd=ON
25+
check_connection=ON
2526
cocoa=ON
2627
minuit2_omp=OFF
2728
x11=OFF

0 commit comments

Comments
 (0)