[RF] Implement checking param range (#19258)

* [RF] Check range of Breit-Wigner

* [RF] Check range of Chi-Square

* [RF] Check param range of BifurGauss

* [RF] Check param range of Poisson

Author: Ban42

roofit/roofit/src/RooBifurGauss.cxx

@@ -24,6 +24,7 @@ side of maximum value.
 #include <RooBifurGauss.h>
 
 #include "RooBatchCompute.h"
+#include "RooHelpers.h"
 
 #include <RooFit/Detail/MathFuncs.h>
 
@@ -39,6 +40,7 @@ RooBifurGauss::RooBifurGauss(const char *name, const char *title, RooAbsReal &_x
      sigmaR("sigmaR", "Right Sigma", this, _sigmaR)
 
 {
+   RooHelpers::checkRangeOfParameters(this, {&_sigmaL, &_sigmaR}, 0.);
 }
 
 ////////////////////////////////////////////////////////////////////////////////

roofit/roofit/src/RooBreitWigner.cxx

@@ -27,6 +27,7 @@ that models a non-relativistic Breit-Wigner shape
 
 #include "RooBreitWigner.h"
 #include "RooRealVar.h"
+#include "RooHelpers.h"
 #include "RooBatchCompute.h"
 
 
@@ -40,6 +41,7 @@ RooBreitWigner::RooBreitWigner(const char *name, const char *title,
   mean("mean","Mean",this,_mean),
   width("width","Width",this,_width)
 {
+   RooHelpers::checkRangeOfParameters(this, {&_width}, 0.);
 }
 
 ////////////////////////////////////////////////////////////////////////////////

roofit/roofit/src/RooChiSquarePdf.cxx

@@ -18,6 +18,7 @@ Here we also implement the analytic integral.
 #include "RooChiSquarePdf.h"
 #include "RooRealVar.h"
 #include "RooBatchCompute.h"
+#include "RooHelpers.h"
 
 #include "TMath.h"
 
@@ -39,6 +40,7 @@ RooChiSquarePdf::RooChiSquarePdf(const char* name, const char* title,
   _x("x", "Dependent", this, x),
   _ndof("ndof","ndof", this, ndof)
 {
+   RooHelpers::checkRangeOfParameters(this, {&x, &ndof}, 0.);
 }
 
 ////////////////////////////////////////////////////////////////////////////////

roofit/roofit/src/RooPoisson.cxx

@@ -17,24 +17,19 @@ Poisson pdf
 #include "RooMath.h"
 #include "RooNaNPacker.h"
 #include "RooBatchCompute.h"
+#include "RooHelpers.h"
 
 #include <RooFit/Detail/MathFuncs.h>
 
 #include <array>
 
+ ////////////////////////////////////////////////////////////////////////////////
+ /// Constructor
 
-////////////////////////////////////////////////////////////////////////////////
-/// Constructor
-
-RooPoisson::RooPoisson(const char *name, const char *title,
-             RooAbsReal::Ref _x,
-             RooAbsReal::Ref _mean,
-             bool noRounding) :
-  RooAbsPdf(name,title),
-  x("x","x",this,_x),
-  mean("mean","mean",this,_mean),
-  _noRounding(noRounding)
-{
+ RooPoisson::RooPoisson(const char *name, const char *title, RooAbsReal::Ref _x, RooAbsReal::Ref _mean, bool noRounding)
+    : RooAbsPdf(name, title), x("x", "x", this, _x), mean("mean", "mean", this, _mean), _noRounding(noRounding)
+ {
+    RooHelpers::checkRangeOfParameters(this, {&static_cast<RooAbsReal &>(_x), &static_cast<RooAbsReal &>(_mean)}, 0.);
 }
 
 ////////////////////////////////////////////////////////////////////////////////