Skip to content

Commit e7bab88

Browse files
authored
[core] fix signed comparison
1 parent 3524249 commit e7bab88

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

core/base/src/TBuffer.cxx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,13 @@ void TBuffer::AutoExpand(ULong64_t size_needed)
159159
if (size_needed > kMaxBufferSize) {
160160
Fatal("AutoExpand","Request to expand a too large buffer: 0x%llx for a max of 0x%x.", size_needed, kMaxBufferSize);
161161
}
162-
if (size_needed > fBufSize) {
162+
auto size_asked = Long64_t(size_needed); // temporary cast as long as fBufSize keeps being a signed variable
163+
if (size_asked > fBufSize) {
163164
Long64_t doubling = 2LLU * fBufSize;
164165
if (doubling > kMaxBufferSize)
165166
doubling = kMaxBufferSize;
166-
if (size_needed > doubling) {
167-
Expand(size_needed);
167+
if (size_asked > doubling) {
168+
Expand(size_asked);
168169
} else {
169170
Expand(doubling);
170171
}

0 commit comments

Comments
 (0)