[hist] Implement initial RHistAutoAxisFiller
#20180
Conversation
I missed this example in commit 943ee82 ("Accept regular axis interval as std::pair").
hahnjo
changed the title
RHistAutoAxisFiller
Test Results 22 files 22 suites 3d 19h 18m 39s ⏱️ Results for commit 8bb1c23. ♻️ This comment has been updated with latest results. |
| /// \see Flush() | ||
| RHist<BinContentType> &GetHist() | ||
| { | ||
| Flush(); |
There was a problem hiding this comment.
That means that we can't get an empty histogram from the auto filler. Is this the desired behavior?
There was a problem hiding this comment.
Yes correct. It's a good question what we want to happen in this case. If we want to allow an empty histogram, what would be the axis interval and what would we want to happen in case of further fills? Would we modify the constructed histogram (potentially) behind the users' back? If there are many fills, how would the user tell is that now is the time to flush the buffer, while they are already looking at the histogram?
I think my proposal for the moment would be to disallow and see if it poses problems that we find a good compromise how to address.
| /// | ||
| /// Throws an exception if the buffer is empty, the axis interval cannot be determined, or if it would be empty | ||
| /// because the minimum equals the maximum. | ||
| void Flush() |
There was a problem hiding this comment.
Do we want/need to expose this publicly?
There was a problem hiding this comment.
Another good question. A potential use case would be where the user designates a limited set of "sample" entries that are potentially not aligned with fMaxBufferSize, or multiple RHistAutoAxisFiller with different fill frequencies that the user wants to "synchronize".
To fill a regular one-dimensional histogram without specifying an axis interval during construction.
3 participants
To fill a regular one-dimensional histogram without specifying an axis interval during construction.