[hist] Implement RHistEngine::FillAtomic
#20183
Open
+645
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 18h 42m 53s ⏱️ Results for commit 5e95c31. ♻️ This comment has been updated with latest results. |
hahnjo
force-pushed
the
hist-atomic
branch
2 times, most recently
from
e887602 to
2a971f1
Compare
std::atomic_ref in C++20 will offer a portable way to apply atomic operations to a referenced object, but for now implement a minimal version ourselves with compiler builtins.
|
It seems the latest code works fine to implement atomic operations on Windows 🥳 |
jblomer
reviewed
Oct 27, 2025
This includes RBinWithError, but also user-defined bin content types.
Done (it's of course not a guarantee that everything is right since reliably testing race conditions is hard) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.