[VecOps] Apply comments in review

* Remove unused include
* Initialize the vectors with values to avoid unwanted optimizations

Author: stwunsch

root/math/vecops/VecOpsRVec.cxx

@@ -1,6 +1,5 @@
 #include "ROOT/RVec.hxx"
 #include "benchmark/benchmark.h"
-#include "rootbench/RBConfig.h"
 
 using namespace ROOT::VecOps;
 
@@ -11,13 +10,22 @@ static void GetArguments(benchmark::internal::Benchmark* b)
       b->Arg(i);
 }
 
+template <class T>
+RVec<T> GenerateSeq(const unsigned int size, const T start = 0)
+{
+   RVec<T> v(size);
+   for (auto i = 0u; i < size; i++)
+      v[i] = start + i;
+   return v;
+}
+
 
 template <class T>
 static void RVecAssign(benchmark::State &state)
 {
    const auto size = state.range(0);
-   RVec<T> v1(size);
-   RVec<T> v2(size);
+   auto v1 = GenerateSeq<T>(size);
+   auto v2 = GenerateSeq<T>(size, size);
    for (auto _ : state) {
       v2 = v1;
       benchmark::DoNotOptimize(v2);
@@ -30,8 +38,8 @@ template <class T>
 static void RVecAdd(benchmark::State &state)
 {
    const auto size = state.range(0);
-   RVec<T> v1(size);
-   RVec<T> v2(size);
+   auto v1 = GenerateSeq<T>(size);
+   auto v2 = GenerateSeq<T>(size, size);
    for (auto _ : state) {
       benchmark::DoNotOptimize(v1 + v2);
    }
@@ -43,8 +51,8 @@ template <class T>
 static void RVecSquareAddSqrt(benchmark::State &state)
 {
    const auto size = state.range(0);
-   RVec<T> v1(size);
-   RVec<T> v2(size);
+   auto v1 = GenerateSeq<T>(size);
+   auto v2 = GenerateSeq<T>(size, size);
    for (auto _ : state) {
       benchmark::DoNotOptimize(sqrt(pow(v1, 2) + pow(v2, 2)));
    }
@@ -56,10 +64,10 @@ template <class T>
 static void RVecDeltaR(benchmark::State &state)
 {
    const auto size = state.range(0);
-   RVec<T> eta1(size);
-   RVec<T> eta2(size);
-   RVec<T> phi1(size);
-   RVec<T> phi2(size);
+   auto eta1 = GenerateSeq<T>(size, 0);
+   auto eta2 = GenerateSeq<T>(size, 1);
+   auto phi1 = GenerateSeq<T>(size, 2);
+   auto phi2 = GenerateSeq<T>(size, 3);
    for (auto _ : state) {
       benchmark::DoNotOptimize(DeltaR(eta1, eta2, phi1, phi2));
    }
@@ -71,10 +79,10 @@ template <class T>
 static void RVecInvariantMass(benchmark::State &state)
 {
    const auto size = state.range(0);
-   RVec<T> pt(size);
-   RVec<T> eta(size);
-   RVec<T> phi(size);
-   RVec<T> mass(size);
+   auto pt = GenerateSeq<T>(size, 0);
+   auto eta = GenerateSeq<T>(size, 1);
+   auto phi = GenerateSeq<T>(size, 2);
+   auto mass = GenerateSeq<T>(size, 3);
    for (auto _ : state) {
       benchmark::DoNotOptimize(InvariantMass(pt, eta, phi, mass));
    }
@@ -86,31 +94,21 @@ template <class T>
 static void RVecInvariantMasses(benchmark::State &state)
 {
    const auto size = state.range(0);
-   RVec<T> pt1(size);
-   RVec<T> pt2(size);
-   RVec<T> eta1(size);
-   RVec<T> eta2(size);
-   RVec<T> phi1(size);
-   RVec<T> phi2(size);
-   RVec<T> mass1(size);
-   RVec<T> mass2(size);
+   auto pt1 = GenerateSeq<T>(size, 0);
+   auto eta1 = GenerateSeq<T>(size, 1);
+   auto phi1 = GenerateSeq<T>(size, 2);
+   auto mass1 = GenerateSeq<T>(size, 3);
+   auto pt2 = GenerateSeq<T>(size, 4);
+   auto eta2 = GenerateSeq<T>(size, 5);
+   auto phi2 = GenerateSeq<T>(size, 6);
+   auto mass2 = GenerateSeq<T>(size, 7);
    for (auto _ : state) {
       benchmark::DoNotOptimize(InvariantMasses(pt1, eta1, phi1, mass1, pt2, eta2, phi2, mass2));
    }
 }
 BENCHMARK_TEMPLATE(RVecInvariantMasses, float)->Apply(GetArguments);
 
 
-template <class T>
-RVec<T> GenerateSeq(const unsigned int size)
-{
-   RVec<T> v(size);
-   for (auto i = 0u; i < size; i++)
-      v[i] = i;
-   return v;
-}
-
-
 template <class T>
 static void RVecMaskingSimple(benchmark::State &state)
 {