[WIP] Add memory measurements to interpreted PyROOT #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve memory measurements for ROOT interpreter benchmark
vgvassilev
reviewed
Jul 15, 2019
lib/MemoryMeasurement.cxx
Outdated
| #include <unistd.h> | ||
| #include <chrono> | ||
| #include <stdlib.h> | ||
| #include "rootbench/RBConfig.h" |
Member
There was a problem hiding this comment.
Includes should be in reverse order, that is, less generic to more generic.
Contributor
Author
There was a problem hiding this comment.
Thanks! I will change the order.
lib/MemoryMeasurement.cxx
Outdated
|
|
||
| std::string getMemoryStats(const std::string& dir, const std::string& filename, std::string& rootInvocation, const std::string& rootexe, const std::string& endInvoc) { | ||
| std::string perffile=""; | ||
| if (access("/usr/bin/time", X_OK) == 0) { |
Member
There was a problem hiding this comment.
We should not hardcode this path /usr/bin/time, we should use a more standard way to resolve a system binary.
Contributor
Author
There was a problem hiding this comment.
alright! I will try to change it.
lib/MemoryMeasurement.cxx
Outdated
| // FIXME: no source in /usr/dash | ||
| // We are writing /usr/bin/time -v output in file to get maximum resident memory for the benchmark | ||
| rootInvocation = "/usr/bin/time -v -o \"" + perffile + rootexe + fullpath + endInvoc; | ||
| std::cout<<"helllloooooooooooooooooooo "<< rootInvocation <<" hellllllloooooooooooooo"<<std::endl; |
Contributor
Author
There was a problem hiding this comment.
Yes sorry, forgot to remove them.
Contributor
|
Closing in favor of #190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve memory measurements for ROOT interpreter benchmark