Track failed pipeline builds in admin dashboard (#2)

* Track failed pipeline builds in admin dashboard

Previously, failed builds were invisible — the build row was only
inserted after a successful build. Now the pipeline records a row with
status "failed" and the error message when any step fails. The admin
dashboard shows these with a red badge and error tooltip on hover.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix failed build ID collisions with successful builds

Use the failure timestamp with a "-failed" suffix for the build ID
instead of the pipeline start time, preventing PK collisions with
successful builds created by repository.Build in the same pipeline run.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: retlehs

cmd/wpcomposer/cmd/pipeline.go

@@ -1,6 +1,10 @@
 package cmd
 
 import (
+	"context"
+	"fmt"
+	"time"
+
 	"github.com/spf13/cobra"
 )
 
@@ -16,40 +20,69 @@ func runPipeline(cmd *cobra.Command, args []string) error {
 	discoverSource, _ := cmd.Flags().GetString("discover-source")
 
 	ctx := cmd.Context()
+	started := time.Now().UTC()
+
+	if err := executePipelineSteps(cmd, ctx, skipDiscover, skipDeploy, discoverSource); err != nil {
+		recordFailedBuild(cmd, started, err)
+		return err
+	}
+
+	application.Logger.Info("pipeline: complete")
+	return nil
+}
 
+func executePipelineSteps(cmd *cobra.Command, ctx context.Context, skipDiscover, skipDeploy bool, discoverSource string) error {
 	if !skipDiscover {
 		application.Logger.Info("pipeline: running discover")
 		discoverCmd.SetContext(ctx)
 		_ = discoverCmd.Flags().Set("source", discoverSource)
 		if err := runDiscover(discoverCmd, nil); err != nil {
-			return err
+			return fmt.Errorf("discover: %w", err)
 		}
 	}
 
 	application.Logger.Info("pipeline: running update")
 	updateCmd.SetContext(ctx)
 	if err := runUpdate(updateCmd, nil); err != nil {
-		return err
+		return fmt.Errorf("update: %w", err)
 	}
 
 	application.Logger.Info("pipeline: running build")
 	buildCmd.SetContext(ctx)
 	if err := runBuild(buildCmd, nil); err != nil {
-		return err
+		return fmt.Errorf("build: %w", err)
 	}
 
 	if !skipDeploy {
 		application.Logger.Info("pipeline: running deploy")
 		deployCmd.SetContext(ctx)
 		if err := runDeploy(deployCmd, nil); err != nil {
-			return err
+			return fmt.Errorf("deploy: %w", err)
 		}
 	}
 
-	application.Logger.Info("pipeline: complete")
 	return nil
 }
 
+func recordFailedBuild(cmd *cobra.Command, started time.Time, pipelineErr error) {
+	now := time.Now().UTC()
+	buildID := now.Format("20060102-150405") + "-failed"
+	_, dbErr := application.DB.ExecContext(cmd.Context(), `
+		INSERT INTO builds (id, started_at, finished_at, duration_seconds,
+			packages_total, packages_changed, packages_skipped,
+			provider_groups, artifact_count, root_hash, sync_run_id, status, manifest_json, error_message)
+		VALUES (?, ?, ?, ?, 0, 0, 0, 0, 0, '', NULL, 'failed', '{}', ?)`,
+		buildID,
+		started.Format(time.RFC3339),
+		now.Format(time.RFC3339),
+		int(now.Sub(started).Seconds()),
+		pipelineErr.Error(),
+	)
+	if dbErr != nil {
+		application.Logger.Warn("failed to record failed build in database", "error", dbErr)
+	}
+}
+
 func init() {
 	appCommand(pipelineCmd)
 	pipelineCmd.Flags().String("discover-source", "config", "discovery source (config or svn)")

internal/http/handlers.go

@@ -758,11 +758,13 @@ type buildRow struct {
 	Status          string
 	IsCurrent       bool
 	R2SyncedAt      string
+	ErrorMessage    string
 }
 
 func queryBuilds(ctx context.Context, db *sql.DB) ([]buildRow, error) {
 	rows, err := db.QueryContext(ctx, `SELECT id, started_at, packages_total, packages_changed,
-		artifact_count, status, COALESCE(r2_synced_at, '') FROM builds ORDER BY started_at DESC LIMIT 50`)
+		artifact_count, status, COALESCE(r2_synced_at, ''), COALESCE(error_message, '')
+		FROM builds ORDER BY started_at DESC LIMIT 50`)
 	if err != nil {
 		return nil, err
 	}
@@ -771,7 +773,7 @@ func queryBuilds(ctx context.Context, db *sql.DB) ([]buildRow, error) {
 	var builds []buildRow
 	for rows.Next() {
 		var b buildRow
-		_ = rows.Scan(&b.ID, &b.StartedAt, &b.PackagesTotal, &b.PackagesChanged, &b.ArtifactCount, &b.Status, &b.R2SyncedAt)
+		_ = rows.Scan(&b.ID, &b.StartedAt, &b.PackagesTotal, &b.PackagesChanged, &b.ArtifactCount, &b.Status, &b.R2SyncedAt, &b.ErrorMessage)
 		builds = append(builds, b)
 	}
 	return builds, rows.Err()

internal/http/templates/admin_builds.html

@@ -28,6 +28,7 @@ <h1 class="text-xl font-bold mb-6">Build History</h1>
 <td class="px-4 py-2 text-right">{{.ArtifactCount}}</td>
 <td class="px-4 py-2">
 {{if .IsCurrent}}<span class="text-xs bg-green-100 text-green-700 px-2 py-0.5 rounded-full">Current</span>
+{{else if eq .Status "failed"}}<span class="text-xs bg-red-100 text-red-700 px-2 py-0.5 rounded-full" title="{{.ErrorMessage}}">Failed</span>
 {{else}}<span class="text-xs bg-gray-100 text-gray-600 px-2 py-0.5 rounded-full">{{.Status}}</span>{{end}}
 </td>
 <td class="px-4 py-2">

migrations/009_add_error_message_to_builds.sql

@@ -0,0 +1,5 @@
+-- +goose Up
+ALTER TABLE builds ADD COLUMN error_message TEXT;
+
+-- +goose Down
+ALTER TABLE builds DROP COLUMN error_message;