Merge pull request #3 from rootstrap/add-specs

Add specs

Author: santib

.rubocop.yml

@@ -1,5 +1,10 @@
+plugins:
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 3.1
+  NewCops: enable
 
 Lint/MissingSuper:
   Enabled: false

Gemfile

@@ -11,3 +11,5 @@ gem "rake", "~> 13.0"
 gem "rspec", "~> 3.0"
 
 gem "rubocop", "~> 1.21"
+gem "rubocop-rake", "~> 0.7"
+gem "rubocop-rspec", "~> 3.7"

lib/mars.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 require_relative "mars/version"
+require_relative "mars/runnable"
+require_relative "mars/workflows/sequential"
 
 module Mars
   class Error < StandardError; end

mars.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/rootstrap/mars"
   spec.metadata["changelog_uri"] = "https://github.com/rootstrap/mars/releases"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

spec/mars/runnable_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+RSpec.describe Mars::Runnable do
+  describe "#run" do
+    context "when called directly on the base class" do
+      let(:runnable) { described_class.new }
+
+      it "raises NotImplementedError" do
+        expect { runnable.run("any input") }.to raise_error(NotImplementedError)
+      end
+    end
+
+    context "when implemented in a subclass" do
+      let(:test_runnable_class) do
+        Class.new(Mars::Runnable) do
+          def run(input)
+            "processed: #{input}"
+          end
+        end
+      end
+
+      let(:runnable) { test_runnable_class.new }
+
+      it "can be successfully overridden" do
+        result = runnable.run("test input")
+        expect(result).to eq("processed: test input")
+      end
+    end
+
+    context "when subclass doesn't override run method" do
+      let(:incomplete_runnable_class) do
+        Class.new(Mars::Runnable) do
+          # Intentionally not overriding run method
+        end
+      end
+
+      let(:runnable) { incomplete_runnable_class.new }
+
+      it "still raises NotImplementedError" do
+        expect { runnable.run("input") }.to raise_error(NotImplementedError)
+      end
+    end
+  end
+
+  describe "inheritance" do
+    it "can be inherited" do
+      subclass = Class.new(described_class)
+      expect(subclass.ancestors).to include(described_class)
+    end
+  end
+end

spec/mars/workflows/sequential_spec.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+RSpec.describe Mars::Workflows::Sequential do
+  let(:add_step_class) do
+    Class.new do
+      def initialize(value)
+        @value = value
+      end
+
+      def run(input)
+        input + @value
+      end
+    end
+  end
+
+  let(:multiply_step_class) do
+    Class.new do
+      def initialize(multiplier)
+        @multiplier = multiplier
+      end
+
+      def run(input)
+        input * @multiplier
+      end
+    end
+  end
+
+  let(:error_step_class) do
+    Class.new do
+      def initialize(message)
+        @message = message
+      end
+
+      def run(_input)
+        raise StandardError, @message
+      end
+    end
+  end
+
+  describe "#run" do
+    it "executes steps sequentially" do
+      add_five = add_step_class.new(5)
+      multiply_three = multiply_step_class.new(3)
+      add_two = add_step_class.new(2)
+
+      workflow = described_class.new("math_workflow", steps: [add_five, multiply_three, add_two])
+
+      # 10 + 5 = 15, 15 * 3 = 45, 45 + 2 = 47
+      expect(workflow.run(10)).to eq(47)
+    end
+
+    it "handles single step" do
+      multiply_step = multiply_step_class.new(7)
+      workflow = described_class.new("single_step", steps: [multiply_step])
+
+      expect(workflow.run(6)).to eq(42)
+    end
+
+    it "returns input unchanged when no steps" do
+      workflow = described_class.new("empty", steps: [])
+
+      expect(workflow.run(42)).to eq(42)
+    end
+
+    it "propagates errors from steps" do
+      add_step = add_step_class.new(5)
+      error_step = error_step_class.new("Step failed")
+
+      workflow = described_class.new("error_workflow", steps: [add_step, error_step])
+
+      expect { workflow.run(10) }.to raise_error(StandardError, "Step failed")
+    end
+  end
+
+  describe "inheritance" do
+    it "inherits from Mars::Runnable" do
+      workflow = described_class.new("test", steps: [])
+      expect(workflow).to be_a(Mars::Runnable)
+    end
+  end
+end

spec/mars_spec.rb

@@ -2,10 +2,6 @@
 
 RSpec.describe Mars do
   it "has a version number" do
-    expect(Mars::VERSION).not_to be nil
-  end
-
-  it "does something useful" do
-    expect(true).to eq(true)
+    expect(Mars::VERSION).not_to be_nil
   end
 end