Skip to content

Commit 213db45

Browse files
authored
Merge pull request #24 from rootstrap/chore/ci_run_lint_test_and_type_check_on_every_pull_request
chore(ci): run lint, test and type check on every pull request
2 parents 303435f + 080a27f commit 213db45

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/lint-ts.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# ✍️ Description:
55
# This action is used to run eslint checks
6-
# Runs on pull requests and pushes to the main/master branches
6+
# Runs on any pull request, and also when pushing to main/master
77
# Based on the event type:
88
# - If it's a pull request, it will run eslint, then add the check to the PR as well as annotate the code with the errors and warnings.
99
# - If it's a push to main/master, it will run the type checking and fail if there are any errors.
@@ -16,7 +16,7 @@ on:
1616
push:
1717
branches: [main, master]
1818
pull_request:
19-
branches: [main, master]
19+
types: [opened, synchronize]
2020

2121
jobs:
2222
lint:

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# ✍️ Description:
55
# This action is used to run unit tests
6-
# Runs on pull requests and pushes to the main/master branches
6+
# Runs on any pull request, and also when pushing to main/master
77
# Based on the event type:
88
# - If it's a pull request, it will run the tests and post a comment with coverage details.
99
# - If it's a push to main/master, it will run the tests and add the check to the commit.
@@ -16,7 +16,7 @@ on:
1616
push:
1717
branches: [main, master]
1818
pull_request:
19-
branches: [main, master]
19+
types: [opened, synchronize]
2020

2121
jobs:
2222
test:

.github/workflows/type-check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# ✍️ Description:
55
# This action is used to run the type-check on the project.
6-
# Runs on pull requests and pushes to the main/master branches
6+
# Runs on any pull request, and also when pushing to main/master
77
# Based on the event type:
88
# - If it's a pull request, it will run type checking, then add the check to the PR as well as annotate the code with the errors using reviewdog.
99
# - If it's a push to main/master, it will run the type checking and fail if there are any errors.
@@ -16,7 +16,7 @@ on:
1616
push:
1717
branches: [main, master]
1818
pull_request:
19-
branches: [main, master]
19+
types: [opened, synchronize]
2020

2121
jobs:
2222
type-check:

0 commit comments

Comments
 (0)