Skip to content

Commit 57400b1

Browse files
fix(sonar): define a constant instead of duplicating
1 parent 6abb2bd commit 57400b1

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

src/ui/select.test.tsx

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ import { Select } from './select';
1010
afterEach(cleanup);
1111

1212
describe('Select component ', () => {
13+
const SELECT_TRIGGER = 'select-trigger';
14+
const SELECT_LABEL = 'select-label';
15+
const SELECT_ERROR = 'select-error';
1316
const options: Option[] = [
1417
{ value: 'chocolate', label: 'Chocolate' },
1518
{ value: 'strawberry', label: 'Strawberry' },
@@ -25,8 +28,8 @@ describe('Select component ', () => {
2528
testID="select"
2629
/>
2730
);
28-
expect(screen.getByTestId('select-trigger')).toBeOnTheScreen();
29-
expect(screen.getByTestId('select-label')).toBeOnTheScreen();
31+
expect(screen.getByTestId(SELECT_TRIGGER)).toBeOnTheScreen();
32+
expect(screen.getByTestId(SELECT_LABEL)).toBeOnTheScreen();
3033
});
3134

3235
it('should render the label correctly ', () => {
@@ -39,9 +42,9 @@ describe('Select component ', () => {
3942
testID="select"
4043
/>
4144
);
42-
expect(screen.getByTestId('select-trigger')).toBeOnTheScreen();
43-
expect(screen.getByTestId('select-label')).toBeOnTheScreen();
44-
expect(screen.getByTestId('select-label')).toHaveTextContent('Select');
45+
expect(screen.getByTestId(SELECT_TRIGGER)).toBeOnTheScreen();
46+
expect(screen.getByTestId(SELECT_LABEL)).toBeOnTheScreen();
47+
expect(screen.getByTestId(SELECT_LABEL)).toHaveTextContent('Select');
4548
});
4649

4750
it('should render the error correctly ', () => {
@@ -55,9 +58,9 @@ describe('Select component ', () => {
5558
error="Please select an option"
5659
/>
5760
);
58-
expect(screen.getByTestId('select-trigger')).toBeOnTheScreen();
59-
expect(screen.getByTestId('select-error')).toBeOnTheScreen();
60-
expect(screen.getByTestId('select-error')).toHaveTextContent(
61+
expect(screen.getByTestId(SELECT_TRIGGER)).toBeOnTheScreen();
62+
expect(screen.getByTestId(SELECT_ERROR)).toBeOnTheScreen();
63+
expect(screen.getByTestId(SELECT_ERROR)).toHaveTextContent(
6164
'Please select an option'
6265
);
6366
});
@@ -72,7 +75,7 @@ describe('Select component ', () => {
7275
/>
7376
);
7477

75-
const selectTrigger = screen.getByTestId('select-trigger');
78+
const selectTrigger = screen.getByTestId(SELECT_TRIGGER);
7679
fireEvent.press(selectTrigger);
7780

7881
expect(screen.getByTestId('select-item-chocolate')).toBeOnTheScreen();

0 commit comments

Comments
 (0)