Skip to content

Commit 7cb3332

Browse files
chore: add jira board reference and screenshots to the pull request t… (#122)
* chore: add jira board reference and screenshots to the pull request template * fix: matching string when modifying pr template on project creation
1 parent 24b4b63 commit 7cb3332

File tree

2 files changed

+58
-2
lines changed

2 files changed

+58
-2
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 57 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,24 @@ Make sure the base repository is `rootstrap/react-native-template` BEFORE creati
55
❌❌❌
66
-->
77

8+
#### Jira board reference:
9+
10+
- [Jira_Card_Name](https://rootstrap.atlassian.net/browse/ABC-123)
11+
12+
---
13+
814
## What does this do?
915

1016
<!---
11-
_Describe what your changes **do**; did you add a $COOL_FEATURE? Write about it here._
17+
🔹 Just a link to JIRA is not enough
18+
🔹 Have in mind not all reviewers might have access to the JIRA board
19+
🔹 Provide a brief and clear description of the changes introduced in this PR.
20+
🔹 What new functionality or improvements were added?
21+
🔹 If this PR is related to a past PR mention it (e.g., "Completes #123").
1222
-->
1323

24+
---
25+
1426
## Why did you do this?
1527

1628
<!---
@@ -28,3 +40,47 @@ _Does your code affect something downstream? Are there side effects people shoul
2840
<!---
2941
_How did you test your change? Document it here._
3042
-->
43+
44+
- [ ] Tested on iOS
45+
- [ ] Tested on Android
46+
- [ ] Tested on a small device
47+
- [ ] Tested on a real device
48+
- [ ] Tested all flows related with this PR changes
49+
- [ ] Tested accessibility
50+
- [ ] Added tests
51+
52+
---
53+
54+
#### Notes:
55+
56+
<!---
57+
📝 Add any additional notes, caveats, or follow-ups here.
58+
-->
59+
60+
---
61+
62+
## **Screenshots / Previews**
63+
64+
<!---
65+
📸 Add screenshots or screen recordings if relevant.
66+
-->
67+
68+
<!--- IF BUG
69+
70+
| Before | After |
71+
| ------------------------------------------- | ------------------------------------------ |
72+
| <img width='350' src='BEFORE_IMAGE_URL'/> | <img width='350' src='AFTER_IMAGE_URL'/> |
73+
74+
-->
75+
76+
🧑‍🎨 **Figma Design**:
77+
78+
<img width='350' src='BEFORE_IMAGE_URL'/>
79+
80+
📱 **Android**:
81+
82+
<img width='350' src='BEFORE_IMAGE_URL'/>
83+
84+
📱 **iOS**:
85+
86+
<img width='350' src='BEFORE_IMAGE_URL'/>

cli/setup-project.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ const updateGitHubWorkflows = (projectName) => {
130130
fileName: '.github/PULL_REQUEST_TEMPLATE.md',
131131
replacements: [
132132
{
133-
searchValue: /^[\s\S]*?(?=## What does this do\?)/,
133+
searchValue: /^[\s\S]*?(?=#### Jira board reference:)/,
134134
replaceValue: '',
135135
},
136136
],

0 commit comments

Comments
 (0)