Skip to content

Commit a053df2

Browse files
naxeynaxey
authored
Fix typos in GitHub Actions (obytes#309)
* fix typo in compress-images.yml * fix typo in e2e-android-eas-build.yml * fix typo in e2e-android-maestro.yml * fix typo in e2e-android.yml * fix typo in eas-build-prod.yml * fix typo in eas-build-prod.yml * fix typo in eas-build-qa.yml * fix typo in expo-doctor.yml * fix typo in lint-ts.yml * fix typo in new-app-version.yml * fix typo in new-github-release.yml * fix typos in test.yml * fix typo in type-check.yml
1 parent 0b2eb56 commit a053df2

12 files changed

+33
-33
lines changed

‎.github/workflows/compress-images.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/compress-images.yml
33

44
# ✍️ Description:
5-
# This workflow is used compress images in the repo.
5+
# This workflow is used to compress images in the repo.
66
# This workflow will trigger on a push to the "master" or "main" branch and only run when a new image is added or updated.
77
# If it's the case, it will compress those images and create a pull request with the compressed images.
88

9-
# 🚨 GTHUB SECRETS REQUIRED: None
9+
# 🚨 GITHUB SECRETS REQUIRED: None
1010

1111
name: Compress images
1212
on:

‎.github/workflows/e2e-android-eas-build.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/e2e-android-eas-build.yml
3-
# End to end testing: https://starter.obytes.com/testing/end-to-end-testing/
3+
# End-to-end testing: https://starter.obytes.com/testing/end-to-end-testing/
44

55
# ✍️ Description:
66
# This workflow is used to run end-to-end tests for EAS build on Android.
77
# It uses Maestro Cloud to run tests on Android emulator.
8-
# It downloads the APK from EAS build and trigger the tests on Maestro Cloud with the downloaded APK.
8+
# It downloads the APK from EAS build and triggers the tests on Maestro Cloud with the downloaded APK.
99

10-
# 🚨 GTHUB SECRETS REQUIRED:
10+
# 🚨 GITHUB SECRETS REQUIRED:
1111
# MAESTRO_CLOUD_API_KEY: API key for Maestro Cloud. You can get it from https://cloud.mobile.dev/ci-integration/github-actions#add-your-api-key-secret
1212

1313
name: E2E Tests EAS Build Android (Maestro + Github Action)
@@ -49,7 +49,7 @@ jobs:
4949
fetch-depth: 0
5050

5151
- name: 📦 Install Maestro
52-
run: npm run install-maestro ## we use npm because we dont need to install deps again
52+
run: npm run install-maestro ## We use npm because we don't need to install deps again
5353

5454
- name: Download Test APK
5555
uses: actions/download-artifact@v3

‎.github/workflows/e2e-android-maestro.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/e2e-android.yml
3-
# End to end testing: https://starter.obytes.com/testing/end-to-end-testing/
3+
# End-to-end testing: https://starter.obytes.com/testing/end-to-end-testing/
44

55
# ✍️ Description:
66
# This workflow is used to run end-to-end tests on Android using Maestro Cloud.
77
# As a first step, it will generate a test APK using the Gradle build and then trigger Maestro Cloud to run the tests on the generated APK.
88
# This workflow will be triggered on pull requests (PRs) with the label "android-test-maestro-cloud" or can be manually triggered from the Actions tab.
99

10-
# 🚨 GTHUB SECRETS REQUIRED:
10+
# 🚨 GITHUB SECRETS REQUIRED:
1111
# MAESTRO_CLOUD_API_KEY: API key for Maestro Cloud. You can get it from https://cloud.mobile.dev/ci-integration/github-actions#add-your-api-key-secret
1212

1313
name: E2E Tests Android (Maestro Cloud)

‎.github/workflows/e2e-android.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/e2e-android.yml
3-
# End to end testing: https://starter.obytes.com/testing/end-to-end-testing/
3+
# End-to-end testing: https://starter.obytes.com/testing/end-to-end-testing/
44

55
# ✍️ Description:
66
# This workflow is used to run end-to-end tests on Android using Maestro.
@@ -10,7 +10,7 @@
1010
# This workflow will be triggered on pull requests (PRs) with the label "android-test-github" or can be manually triggered from the Actions tab.
1111
#
1212

13-
# 🚨 GTHUB SECRETS REQUIRED: None
13+
# 🚨 GITHUB SECRETS REQUIRED: None
1414

1515
name: E2E Tests Android (Maestro + Github Action)
1616

@@ -57,7 +57,7 @@ jobs:
5757
fetch-depth: 0
5858

5959
- name: 📦 Install Maestro
60-
run: npm run install-maestro ## we use npm because we dont need to install deps again
60+
run: npm run install-maestro ## We use npm because we don't need to install deps again
6161

6262
- name: Download Test APK
6363
uses: actions/download-artifact@v3

‎.github/workflows/eas-build-prod.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/eas-build-prod.yml
3-
# Starter releasing proccess: https://starter.obytes.com/ci-cd/app-releasing-process/
3+
# Starter releasing process: https://starter.obytes.com/ci-cd/app-releasing-process/
44

55
# ✍️ Description:
66
# This workflow is used to trigger a build on EAS for Prod environment.
77
# Can be triggered manually from the actions tab.
88
# This workflow will use ./actions/eas-build action to trigger the build on EAS with production env.
99

10-
# 🚨 GTHUB SECRETS REQUIRED:
10+
# 🚨 GITHUB SECRETS REQUIRED:
1111
# - EXPO_TOKEN: Expo token to authenticate with EAS
1212
# - You can get it from https://expo.dev/settings/access-tokens
1313

‎.github/workflows/eas-build-qa.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/eas-build-qa.yml
3-
# Starter releasing proccess: https://starter.obytes.com/ci-cd/app-releasing-process/
3+
# Starter releasing process: https://starter.obytes.com/ci-cd/app-releasing-process/
44

55
# ✍️ Description:
6-
# This workflow is used to trigger a build on EAS for QA environment.
7-
# It will run on every Github release published on the repo, or can be triggered manually from the actions tab.
6+
# This workflow is used to trigger a build on EAS for the QA environment.
7+
# It will run on every GitHub release published on the repo or can be triggered manually from the actions tab.
88
# This workflow will use ./actions/eas-build action to trigger the build on EAS with staging env.
99

10-
# 🚨 GTHUB SECRETS REQUIRED:
10+
# 🚨 GITHUB SECRETS REQUIRED:
1111
# - EXPO_TOKEN: Expo token to authenticate with EAS
1212
# - You can get it from https://expo.dev/settings/access-tokens
1313

‎.github/workflows/expo-doctor.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# Can be triggered manually from the Actions tab in your project.
77
# Runs Also on pull requests and pushes to the main/master branch, but only if the `package.json` or `pnpm-lock.yaml` files have been changed.
88

9-
# 🚨 GTHUB SECRETS REQUIRED: NONE
9+
# 🚨 GITHUB SECRETS REQUIRED: NONE
1010

1111
name: Expo Doctor (expo)
1212

‎.github/workflows/lint-ts.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
# - If it's a pull request, it will run eslint, then add the check to the PR as well as annotate the code with the errors and warnings.
99
# - If it's a push to main/master, it will run the type checking and fail if there are any errors.
1010

11-
# 🚨 GTHUB SECRETS REQUIRED: NONE
11+
# 🚨 GITHUB SECRETS REQUIRED: NONE
1212

1313
name: Lint TS (eslint, prettier)
1414

‎.github/workflows/new-app-version.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/lint-ts.yml
3-
# Starter releasing proccess: https://starter.obytes.com/ci-cd/app-releasing-process/
3+
# Starter releasing process: https://starter.obytes.com/ci-cd/app-releasing-process/
44

55
# ✍️ Description:
66
# This workflow is used to create a new version of the app and push a new tag to the repo.
7-
# As this workflow will push code to the repo, we setup Github Bot as git user.
7+
# As this workflow will push code to the repo, we set up GitHub Bot as a Git user.
88
# This Workflow need to be triggered manually from the Actions tab in the repo.
9-
# 1. Choose the your release type (patch, minor, major)
10-
# 2. The workflow will run np-release script which run the following steps:
9+
# 1. Choose your release type (patch, minor, major)
10+
# 2. The workflow will run the np-release script which runs the following steps:
1111
# - Bump the version in package.json based on the release type using np
12-
# - Run the prebuild the app to align the package.json version with the native code
12+
# - Run the prebuild of the app to align the package.json version with the native code
1313
# - Create a new tag with the new version
1414
# - Push the new tag to the repo
1515
#
1616

17-
# 🚨 GTHUB SECRETS REQUIRED:
18-
# - GH_TOKEN: A Github token with write repo access.
19-
# you can generate one from here: https://docs.github.com/en/[email protected]/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens
17+
# 🚨 GITHUB SECRETS REQUIRED:
18+
# - GH_TOKEN: A GitHub token with write repo access.
19+
# You can generate one from here: https://docs.github.com/en/[email protected]/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens
2020
# make sure to add it to the repo secrets with the name GH_TOKEN
2121

2222
name: New App Version

‎.github/workflows/new-github-release.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# 🔗 Links:
22
# Source file: https://github.com/obytes/react-native-template-obytes/blob/master/.github/workflows/new-github-release.yml
3-
# Starter releasing proccess: https://starter.obytes.com/ci-cd/app-releasing-process/
3+
# Starter releasing process: https://starter.obytes.com/ci-cd/app-releasing-process/
44

55
# ✍️ Description:
66
# This workflow will be triggered automatically after the new app version workflow has been executed successfully.
7-
# It will create a new github release with the new app version and the release notes.
7+
# It will create a new GitHub release with the new app version and the release notes.
88

9-
# 🚨 GTHUB SECRETS REQUIRED: None
9+
# 🚨 GITHUB SECRETS REQUIRED: None
1010

1111
name: New GitHub Release
1212

0 commit comments

Comments
 (0)