Merge pull request #63 from rootstrap/chore/sonar_eslint

fix: braces and parentheses should be used consistently with arrow fu…

Author: fernandatoledo

.eslintrc.js

@@ -71,7 +71,8 @@ module.exports = {
         destructuring: 'any',
       },
     ],
-    'object-shorthand': 'error'
+    'object-shorthand': 'error',
+    'arrow-body-style': ["error", "as-needed"]
   },
   overrides: [
     // Configuration for  translations files (i18next)

src/api/common/interceptors.ts

@@ -16,8 +16,6 @@ export default function interceptors() {
       response.data = toCamelCase(response.data);
       return response;
     },
-    (error: AxiosError) => {
-      return Promise.reject(error);
-    }
+    (error: AxiosError) => Promise.reject(error)
   );
 }

src/api/posts/use-post.ts

@@ -9,9 +9,7 @@ type Response = Post;
 
 export const usePost = createQuery<Response, Variables, AxiosError>({
   queryKey: ['posts'],
-  fetcher: (variables) => {
-    return client
+  fetcher: (variables) => client
       .get(`posts/${variables.id}`)
-      .then((response) => response.data);
-  },
+      .then((response) => response.data),
 });

src/api/posts/use-posts.ts

@@ -9,7 +9,5 @@ type Variables = void; // as react-query-kit is strongly typed, we need to speci
 
 export const usePosts = createQuery<Response, Variables, AxiosError>({
   queryKey: ['posts'],
-  fetcher: () => {
-    return client.get(`posts`).then((response) => response.data.posts);
-  },
+  fetcher: () => client.get(`posts`).then((response) => response.data.posts),
 });

src/app/(app)/_layout.tsx

@@ -64,12 +64,10 @@ export default function TabLayout() {
   );
 }
 
-const CreateNewPostLink = () => {
-  return (
+const CreateNewPostLink = () => (
     <Link href="/feed/add-post" asChild>
       <Pressable>
         <Text className="px-3 text-primary-300">Create</Text>
       </Pressable>
     </Link>
   );
-};

src/components/buttons.tsx

@@ -2,8 +2,7 @@ import { Button, View } from '@/ui';
 
 import { Title } from './title';
 
-export const Buttons = () => {
-  return (
+export const Buttons = () => (
     <>
       <Title text="Buttons" />
       <View>
@@ -47,4 +46,3 @@ export const Buttons = () => {
       </View>
     </>
   );
-};

src/components/card.tsx

@@ -13,8 +13,7 @@ const images = [
   'https://images.unsplash.com/photo-1587974928442-77dc3e0dba72?auto=format&fit=crop&w=800&q=80',
 ];
 
-export const Card = ({ title, body, id }: Props) => {
-  return (
+export const Card = ({ title, body, id }: Props) => (
     <Link href={`/feed/${id}`} asChild>
       <Pressable>
         <View className="m-2 overflow-hidden rounded-xl  border border-neutral-300 bg-white  dark:bg-neutral-900">
@@ -36,4 +35,3 @@ export const Card = ({ title, body, id }: Props) => {
       </Pressable>
     </Link>
   );
-};

src/components/colors.tsx

@@ -4,16 +4,14 @@ import colors from '@/ui/colors';
 import { Title } from './title';
 type ColorName = keyof typeof colors;
 
-export const Colors = () => {
-  return (
+export const Colors = () => (
     <>
       <Title text="Colors" />
       {(Object.keys(colors) as ColorName[]).map((name) => (
         <Color name={name} key={name} />
       ))}
     </>
   );
-};
 
 const Color = ({ name }: { name: ColorName }) => {
   if (typeof colors[name] === 'string') {
@@ -23,22 +21,19 @@ const Color = ({ name }: { name: ColorName }) => {
     <View className="pt-2" testID={`color-list-${name}`}>
       <Text className="font-medium">{name.toUpperCase()}</Text>
       <View className="flex-row flex-wrap content-between justify-around ">
-        {Object.entries(colors[name]).map(([key, value]) => {
-          return (
+        {Object.entries(colors[name]).map(([key, value]) => (
             <ColorCard
               key={`${colors[name]}-${key}`}
               value={key}
               color={value}
             />
-          );
-        })}
+          ))}
       </View>
     </View>
   );
 };
 
-const ColorCard = ({ color, value }: { value: string; color: string }) => {
-  return (
+const ColorCard = ({ color, value }: { value: string; color: string }) => (
     <View className="flex-1">
       <View
         className="h-14 w-full rounded-sm"
@@ -47,4 +42,3 @@ const ColorCard = ({ color, value }: { value: string; color: string }) => {
       <Text className="text-sm">{value}</Text>
     </View>
   );
-};

src/components/settings/items-container.tsx

@@ -6,8 +6,7 @@ type Props = {
   title?: TxKeyPath;
 };
 
-export const ItemsContainer = ({ children, title }: Props) => {
-  return (
+export const ItemsContainer = ({ children, title }: Props) => (
     <>
       {title && <Text className="pb-2 pt-4 text-lg" tx={title} />}
       {
@@ -17,4 +16,3 @@ export const ItemsContainer = ({ children, title }: Props) => {
       }
     </>
   );
-};

src/components/title.tsx

@@ -3,11 +3,9 @@ import { Text, View } from '@/ui';
 type Props = {
   text: string;
 };
-export const Title = ({ text }: Props) => {
-  return (
+export const Title = ({ text }: Props) => (
     <View className="flex-row items-center justify-center  py-4 pb-2">
       <Text className="pr-2 text-2xl">{text}</Text>
       <View className="h-[2px] flex-1 bg-neutral-300" />
     </View>
   );
-};