Adjust review coverage tests

Author: gonzaM

app/controllers/development_metrics_controller.rb

@@ -52,7 +52,7 @@ def build_overall_calculations(entity_name)
     @merge_time_success_rate = merge_time[:success_rate]
     @merge_time_avg = merge_time[:avg]
     @pull_request_size_avg = @pull_request_size[key].first[:avg]
-    @review_coverage_avg = @review_coverage[key].first[:avg]
+    @review_coverage_avg = @review_coverage[key].first[:avg] if @review_coverage.present?
   end
 
   def build_metrics(entity_id, entity_name)

app/services/builders/distribution/pull_requests/pull_request_size_repository.rb

@@ -26,6 +26,7 @@ def pr_sizes
                                              .where.not(
                                                events_pull_requests: { html_url: nil }
                                              )
+                                             .where.not(owner: User.ignored_users)
                                              .where.not(size: nil)
                                              .order(:size)
         end

app/services/builders/distribution/pull_requests/review_coverage_repository.rb

@@ -24,6 +24,7 @@ def review_coverages
                                 .joins(pull_request: :repository)
                                 .where(repositories: { name: @repository_name })
                                 .where(pull_request: { merged_at: @from..@to })
+                                .where.not(pull_request: { owner: User.ignored_users })
                                 .order(:coverage_percentage)
         end
 

app/services/builders/distribution/pull_requests/time_to_merge_repository.rb

@@ -24,6 +24,9 @@ def merge_times
                                       .joins(pull_request: :repository)
                                       .where(repositories: { name: @repository_name })
                                       .where.not(events_pull_requests: { html_url: nil })
+                                      .where.not(
+                                        events_pull_requests: { owner: User.ignored_users }
+                                      )
                                       .includes(:pull_request)
                                       .order(:value)
         end

app/services/metrics/review_coverage/per_repository.rb

@@ -13,7 +13,7 @@ def process
       end
 
       def query(interval)
-        Repository.joins(pull_requests: :review_requests)
+        Repository.joins(pull_requests: :review_coverage)
                   .where(events_pull_requests: { merged_at: interval })
                   .where(id: @entity_id)
                   .group(:id)

app/views/development_metrics/review_coverage/_main_metric.erb

@@ -4,4 +4,4 @@
              metric_name: 'Distribution',
              suffix: " pull requests",
              metric: review_coverage[:per_repository_distribution]
-           } if review_coverage && review_coverage[:per_repository_distribution] %> 
+           } if review_coverage && review_coverage[:per_repository_distribution] %>

app/views/pull_requests/review_coverage_prs_repository/index.erb

@@ -14,4 +14,4 @@
     </div>
   </div>
   <%= render partial: 'shared/pull_request_list' , locals: { pull_requests: @pull_requests, kpi_label: '%' } %>
-</div> 
+</div>

spec/controllers/development_metrics_controller_spec.rb

@@ -18,6 +18,9 @@
   let!(:pull_request_size_metric_definition) do
     create(:metric_definition, code: :pull_request_size)
   end
+  let!(:review_coverage_metric_definition) do
+    create(:metric_definition, code: :review_coverage)
+  end
 
   describe '#index' do
     context 'when metric params are empty' do
@@ -219,17 +222,11 @@
             subject
             expect(response.body).to include(pull_request_size_metric_definition.explanation)
           end
-        end
-      end
-
-      context '#departments' do
-        before { params[:department_name] = repository.language.department.name }
 
-        it 'calls CodeClimate summary retriever class' do
-          expect(CodeClimate::RepositoriesSummaryService)
-            .to receive(:call).and_return(code_climate_metric)
-
-          get :departments, params: params
+          it 'render review coverage metric tooltip' do
+            subject
+            expect(response.body).to include(review_coverage_metric_definition.explanation)
+          end
         end
       end
     end