a few fixes for some other fxns that need to fail with scope info

bump to v0.4.2
update news and cran comments

Author: sckott

DESCRIPTION

@@ -10,9 +10,11 @@ Description: Work with 'GitHub' 'gists' from 'R' (e.g.,
     'gist' 'commits', and get rate limit information when 'authenticated'. Some
     requests require authentication and some do not. 'Gists' website: 
     <https://gist.github.com/>.
-Version: 0.4.1.9313
+Version: 0.4.2
 Authors@R: c(
-    person("Scott", "Chamberlain", role = c("aut", "cre"), email = "[email protected]"),
+    person("Scott", "Chamberlain", role = c("aut", "cre"), 
+        email = "[email protected]", 
+        comment = c(ORCID="0000-0003-1444-9135")),
     person("Ramnath", "Vaidyanathan", role = "aut"),
     person("Karthik", "Ram", role = "aut")
   )
@@ -29,7 +31,6 @@ Imports:
     rmarkdown,
     dplyr
 Suggests:
-    roxygen2 (>= 6.0.1),
     git2r,
     testthat
 RoxygenNote: 6.0.1

NEWS.md

@@ -1,3 +1,16 @@
+gistr 0.4.2
+===============
+
+### NEW FEATURES
+
+* `gist()` gains a parameter `revision` to request a specific revision of a gists. note that the returned brief print out of the gist in your console may not vary from revision to revision, but the underlying data has the correct data for the revision (#71)
+
+### MINOR IMPROVEMENTS
+
+* affecting all functions that create data `gist_create()`, `gist_create_git()`, `gist_create_obj()`, `update()`, `delete()`: GitHub for good reason gives a 404 when there are authentication issues. A common problem is that a user has incorrect or missing scopes. We now attempt to detect this scope problem specifically and throw a message when that happens (#70)
+* toggle whether we index to a git path with `@` vs. `$` depending on `git2r` package version; for an upcoming version of `git2r` (#74)
+
+
 gistr 0.4.0
 ===============
 

R/gist_create_git.R

@@ -263,6 +263,7 @@ cgist <- function(description, public) {
                       )
                     ), auto_unbox = TRUE)
   )
+  stopstatus(res)
   jsonlite::fromJSON(httr::content(res, "text", encoding = "UTF-8"), FALSE)
 }
 

R/rate_limit.R

@@ -4,7 +4,6 @@
 #' @param ... Named args to \code{\link[httr]{GET}}
 #' @examples \dontrun{
 #' rate_limit()
-#' rate_limit(config=verbose())
 #' }
 
 rate_limit <- function(...){

R/update.R

@@ -4,14 +4,15 @@
 #' @param gist A gist object or something coerceable to a gist
 #' @param description (character) Brief description of gist (optional)
 #' @template all
+#' @return 
 #' @examples \dontrun{
 #' file1 <- system.file("examples", "alm.md", package = "gistr")
 #' file2 <- system.file("examples", "zoo.json", package = "gistr")
 #' 
 #' # add new files
 #' gists(what = "minepublic")[[3]] %>%
 #'  add_files(file1, file2) %>%
-#'  update(config = verbose())
+#'  update()
 #'
 #' # update existing files
 #' ### file name has to match to current name

R/zzz.R

@@ -90,7 +90,9 @@ gist_PUT <- function(url, auth, headers, ...){
 }
 
 gist_DELETE <- function(url, auth, headers, ...){
-  DELETE(url, auth, headers, ...)
+  res <- DELETE(url, auth, headers, ...)
+  stopstatus(res, 204)
+  res
 }
 
 process <- function(x){
@@ -100,8 +102,8 @@ process <- function(x){
   jsonlite::fromJSON(temp, FALSE)
 }
 
-stopstatus <- function(x) {
-  if (x$status_code > 203) {
+stopstatus <- function(x, status_stop = 203) {
+  if (x$status_code > status_stop) {
     res <- jsonlite::fromJSON(httr::content(x, as = "text", 
                                             encoding = "UTF-8"), FALSE)
     errs <- sapply(res$errors, function(z) paste(names(z), z, sep = ": ", 

cran-comments.md

@@ -1,7 +1,7 @@
 ## Test environments
 
-* local OS X install, R 3.3.3
-* ubuntu 12.04 (on travis-ci), R 3.3.3
+* local OS X install, R 3.5.0
+* ubuntu 14.04 (on travis-ci), R 3.5.0
 * win-builder (devel and release)
 
 ## R CMD check results
@@ -11,21 +11,16 @@
 License components with restrictions and base license permitting such:
   MIT + file LICENSE
 File 'LICENSE':
-  YEAR: 2017
+  YEAR: 2018
   COPYRIGHT HOLDER: Scott Chamberlain
 
 ## Reverse dependencies
 
-* I have run R CMD check on the 6 downstream dependencies.
-  (Summary at <https://github.com/ropensci/gistr/tree/master/revdep>). 
-* None had problems.
-* All revdep maintainers were notified of the release.
+I have run R CMD check on the 5 downstream dependencies. Summary at <https://github.com/ropensci/gistr/tree/master/revdep>. None had problems.
 
 ---
 
-This version fixes a bug and changes function name in a dependency 
-package in anticipation of a new version of it on CRAN (dplyr).
-
+This version makes a change to accomodate an upcoming change in git2r, one of our dependencies - as well as a few other minor improvements.
 
 Thanks!
 Scott Chamberlain