test: improve readability

Author: maelle

tests/testthat/_snaps/create-pkgreview.md

@@ -1,3 +1,41 @@
+# review-proj-created-correctly
+
+    Code
+      fs::dir_ls(review_dir, all = TRUE)
+    Output
+      /riem-review/.git
+      /riem-review/.gitignore
+      /riem-review/.here
+      /riem-review/R
+      /riem-review/README.md
+      /riem-review/index.Rmd
+      /riem-review/review.md
+
+---
+
+    Code
+      fs::dir_ls(pkg_dir, all = TRUE)
+    Output
+      /riem/.Rbuildignore
+      /riem/.git
+      /riem/.gitattributes
+      /riem/.github
+      /riem/.gitignore
+      /riem/.lintr
+      /riem/DESCRIPTION
+      /riem/NAMESPACE
+      /riem/NEWS.md
+      /riem/R
+      /riem/README.md
+      /riem/_pkgdown.yml
+      /riem/codemeta.json
+      /riem/cran-comments.md
+      /riem/man
+      /riem/pkgdown
+      /riem/riem.Rproj
+      /riem/tests
+      /riem/vignettes
+
 # get-pkg_data
 
     Code

tests/testthat/test-create-pkgreview.R

@@ -7,12 +7,14 @@ test_that("review-proj-created-correctly", {
 
   pkgreview_create("ropensci/riem", review_parent) # nolint: nonportable_path_linter
 
-  expect_true("riem-review" %in% list.files(review_parent))
-  expect_true(
-    all(c("index.Rmd", "README.md", "review.md") %in% list.files(review_dir))
+  expect_true(fs::dir_exists(fs::path(review_parent, "riem-review")))
+  expect_snapshot(
+    fs::dir_ls(review_dir, all =TRUE),
+    transform = function(x) sub(".*riem-review/", "/riem-review/", x)
   )
-  expect_true(
-    all(c("DESCRIPTION", "README.md") %in% list.files(pkg_dir))
+  expect_snapshot(
+    fs::dir_ls(pkg_dir, all =TRUE),
+    transform = function(x) sub(".*riem/", "/riem/", x)
   )
 })