chore: make it more robust

Author: maelle

R/github.R

@@ -37,11 +37,6 @@ check_global_git <- function() {
   }
 }
 
-clone_pkg <- function(pkg_repo, pkg_dir) {
-  fs::dir_create(pkg_dir)
-  usethis::create_from_github(pkg_repo, destdir = pkg_dir, open = FALSE)
-}
-
 get_repo_meta <- function(pkg_repo, full = FALSE) {
   meta <- gh::gh(paste0("/repos/", pkg_repo)) # nolint: paste_linter
 

R/pkgreview.R

@@ -48,7 +48,7 @@ pkgreview_create <- function(pkg_repo, review_parent = ".",
     sprintf("%s-%s", meta[["name"]], template)
   )
 
-  clone_pkg(pkg_repo, pkg_dir = review_parent)
+  create_from_github(pkg_repo, destdir = review_parent, open = FALSE)
 
   # create project
   withr::local_options(list(usethis.quiet = TRUE))
@@ -118,17 +118,14 @@ pkgreview_init <- function(pkg_repo, review_dir = ".",
   }
 
   usethis::create_project(review_dir, open = FALSE)
+  use_onboarding_tmpl(template, destdir = review_dir)
+  pkgreview_index_rmd(pkg_data, template, destdir = review_dir)
 
-  usethis::with_project(review_dir, {
-    # create templates
-    use_onboarding_tmpl(template)
-    pkgreview_index_rmd(pkg_data, template)
-    switch(
-      template,
-      review = pkgreview_readme_md(pkg_data),
-      editor = pkgreview_request(pkg_data)
-    )
-  }, quiet = TRUE)
+  switch(
+    template,
+    review = pkgreview_readme_md(pkg_data, destdir = review_dir),
+    editor = pkgreview_request(pkg_data, destdir = review_dir)
+  )
 
   cli::cli_alert_success(
     "{template} project {.val {basename(review_dir)}} initialised"
@@ -221,14 +218,24 @@ pkgreview_getdata <- function(pkg_repo, pkg_dir = NULL,
 #' @export
 try_whoami <- function() {
   if (isTRUE(as.logical(Sys.getenv("CI")))) {
-    return(
-      list(
-        name = "Maëlle Salmon",
-        login = "maelle",
-        html_url = "https://github.com/maelle"
-      )
+    list(
+      login = "maelle",
+      html_url = "https://github.com/maelle"
     )
   }
-
   try(gh::gh_whoami(gh::gh_token()), silent = TRUE)
 }
+
+create_from_github <- function(pkg_repo, destdir, open) {
+  if (isTRUE(as.logical(Sys.getenv("CI")))) {
+    url <- sprintf(
+      "https://github.com/%s/archive/refs/heads/main.zip",
+      pkg_repo
+    )
+    curl::curl_download(url, destdir)
+    return(TRUE)
+  }
+
+
+  usethis::create_from_github(pkg_repo, destdir = destdir, open = open)
+}

R/render-templates.R

@@ -16,23 +16,27 @@
 # @importFrom usethis getFromNamespace check_installed
 # @importFrom usethis getFromNamespace render_template
 pkgreview_index_rmd <- function(pkg_data,
-                                template = c("review", "editor")) {
+                                template = c("review", "editor"),
+                                destdir) {
   template <- match.arg(template)
 
-  usethis::use_template(
-    sprintf("%s-index", template),
-    "index.Rmd",
-    data = pkg_data,
-    ignore = FALSE,
-    open = FALSE,
-    package = "pkgreviewr"
-  )
+  usethis::with_project(destdir, {
+    usethis::use_template(
+      sprintf("%s-index", template),
+      "index.Rmd",
+      data = pkg_data,
+      ignore = FALSE,
+      open = FALSE,
+      package = "pkgreviewr"
+    )
+  })
   invisible(TRUE)
 }
 
 #' @export
 #' @rdname pkgreview_index_rmd
-pkgreview_readme_md <- function(pkg_data) {
+pkgreview_readme_md <- function(pkg_data, destdir) {
+  usethis::local_project(destdir)
   usethis::use_template(
     "review-README",
     "README.md",
@@ -56,35 +60,31 @@ pkgreview_readme_md <- function(pkg_data) {
 #' \dontrun{
 #' use_onboarding_tmpl(template = "editor")
 #' }
-use_onboarding_tmpl <- function(template = c("review", "editor")) {
+use_onboarding_tmpl <- function(template = c("review", "editor"), destdir) {
   template <- match.arg(template)
   tmpl_txt <- gh::gh("/repos/:owner/:repo/contents/:path",
     owner = "ropensci",
     repo = "dev_guide",
     path = sprintf("templates/%s.md", template) # nolint: nonportable_path_litner
   )
 
-  temp_file <- withr::local_tempfile()
-  curl::curl_download(tmpl_txt[["download_url"]], temp_file)
-  tmpl_txt <- paste(brio::read_lines(temp_file), collapse = "\n")
-
-  new <- usethis::write_over(
-    usethis::proj_path(fs::path_ext_set(template, ".md")),
-    tmpl_txt
+  curl::curl_download(
+    tmpl_txt[["download_url"]],
+    fs::path(destdir, fs::path_ext_set(template, ".md"))
   )
-  invisible(new)
 }
 
 
 
 #' @export
 #' @rdname pkgreview_index_rmd
-pkgreview_request <- function(pkg_data) {
+pkgreview_request <- function(pkg_data, destdir) {
   pkg_data <- c(
     pkg_data,
     editor = try_whoami()[["name"]]
   )
 
+  usethis::local_project(destdir)
   usethis::use_template(
     "request",
     "request.Rmd",