clone_gh_org_repos should respect branch field in packages.json#90
Merged
mpadge merged 3 commits intoropensci-review-tools:mainfrom Mar 2, 2026
Merged
clone_gh_org_repos should respect branch field in packages.json#90mpadge merged 3 commits intoropensci-review-tools:mainfrom
mpadge merged 3 commits intoropensci-review-tools:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 47.28% 47.32% +0.03%
==========================================
Files 12 12
Lines 1510 1513 +3
==========================================
+ Hits 714 716 +2
- Misses 796 797 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Nice, that's a great externsion; thanks @remlapmot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/MRCIEU/mrcieu.r-universe.dev/blob/main/packages.json we have to take quite a few repos from our forks (for some reason people write non-standard R packages in our field quite alot).
We send fixes from a branch on our fork. However this function isn't respecting the
"branch"field, e.g.,{ "package": "BWMR", "url": "https://github.com/remlapmot/BWMR", "branch": "suggestions" },This adds that.
And also R CMD check says 3 non-standard files are found, so I added them to .Rbuildignore.