improve warning on incorrectly-formatted standard numbers

Author: mpadge

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: srr
 Title: 'rOpenSci' Review Roclets
-Version: 0.1.4.034
+Version: 0.1.4.035
 Authors@R: 
     person("Mark", "Padgham", , "mark@ropensci.org", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0003-2172-5265"))

R/roclet.R

@@ -361,7 +361,7 @@ process_srrstats_tags <- function (tag = "srrstats", block,
 
     standards <- roxygen2::block_get_tags (block, tag)
     standards <- unlist (lapply (standards, function (i) i$val))
-    snum <- extract_standard_numbers (standards)
+    snum <- extract_standard_numbers (standards, block)
 
     standards_txt <- vapply (seq_along (snum), function (i) {
         gsub (paste0 ("^.*", snum [i], "\\}"), "", standards [i])
@@ -405,7 +405,7 @@ process_srrstats_tags <- function (tag = "srrstats", block,
 
 # extract the actual standards numbers from arbitrary text strings, first
 # capturing everything inside first "[...]":
-extract_standard_numbers <- function (standards) {
+extract_standard_numbers <- function (standards, block) {
 
     # roxygen parses markdown "**A**" as "\\strong{A}", and the curly braces
     # muck up standards ID, so have to be removed here:
@@ -428,7 +428,9 @@ extract_standard_numbers <- function (standards) {
     standards <- gsub ("\\{|\\}", "", substring (standards, g_open, g_close))
     standards <- gsub ("\\s*", "", unlist (strsplit (standards, ",")))
     if (length (standards) < 1) {
-        stop ("srrstats tags found but no correctly-formatted standard numbers")
+        cli::cli_abort (
+            "srrstats tags in {block$file} line {block$line} have incorrectly-formatted standard numbers"
+        )
     }
 
     return (standards)

codemeta.json

@@ -8,7 +8,7 @@
   "codeRepository": "https://github.com/ropensci-review-tools/srr",
   "issueTracker": "https://github.com/ropensci-review-tools/srr/issues",
   "license": "https://spdx.org/licenses/MIT",
-  "version": "0.1.4.034",
+  "version": "0.1.4.035",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",