Skip to content

Commit 5bb35a9

Browse files
committed
rm superfluous msg from add operator
1 parent d5c5424 commit 5bb35a9

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: RefManageR
2-
Version: 0.14.18
2+
Version: 0.14.19
33
Title: Straightforward 'BibTeX' and 'BibLaTeX' Bibliography Management
44
Authors@R: person(c("Mathew", "W."), "McLean", role = c("aut", "cre"),
55
email = "[email protected]")

R/BibEntryAddOp.R

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@
8181
possible.dup <- unlist(e2$bibtype) %in% unlist(e1$bibtype)
8282
}
8383
remain.dup.f <- setdiff(fields.to.check, c('bibtype', 'key'))
84-
if (length(remain.dup.f)){
84+
85+
if (length(remain.dup.f) && length(dup.ind <- possible.dup)){
8586
dup.ind <- vapply(unclass(e2[possible.dup]),
8687
function(x, y, flds){
8788
x <- x[flds]
@@ -93,8 +94,6 @@
9394
}, FALSE, y = unclass(e1), flds = remain.dup.f)
9495
if (length(dup.ind))
9596
dup.ind <- which(dup.ind)
96-
}else{
97-
dup.ind <- possible.dup
9897
}
9998
if (length(dup.ind) == length(e2)){
10099
message('Only duplicates in second BibEntry object')

inst/NEWS.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Changes in Version 0.14.18 (2017-07-25)
1+
Changes in Version 0.14.19 (2017-07-26)
22
--------------------------------------------------------
33

44
NEW FEATURES
@@ -11,6 +11,8 @@ BUG FIXES
1111
* Remove missing plot from Rhtml vignette
1212
* URL field returned by `GetBibEntryWithDOI` is now decoded properly
1313
* Fix hyperlinks from bibliography to citations in vignettes
14+
* Remove a incorrect message ocassionally output from the addition operator
15+
for `BibEntry` objects
1416

1517
Changes in Version 0.14.12 (2017-06-30)
1618
--------------------------------------------------------

0 commit comments

Comments
 (0)