Usage of arduino-esp32 for board definitions, RadioLib build options, other stuff and many questions...

[Velocet]

Hi there, i really like the idea but something i don't understand: Why not use arduino-esp32 and take the board definitions from it? This way you could use something like this:

#if defined(WIFI_LoRa_32)
  #define RADIOLIB_EXCLUDE_SX126X (1)
  #include LoRa32_HelTec_LoRa.h
#elif defined(WIFI_LoRa_32_V2)
  #define RADIOLIB_EXCLUDE_SX126X (1)
  #include LoRa32_HelTec_LoRaV2.h
#elif defined(WIFI_LoRa_32_V3)
  #define RADIOLIB_EXCLUDE_SX127X (1)
  #include LoRa32_HelTec_LoRaV3.h

#elif defined(Wireless_Stick)
  #define RADIOLIB_EXCLUDE_SX126X (1)
  #define DISPLAY_GEOMETRY GEOMETRY_64_32
  #include LoRa32_HelTec_Stick.h
#elif defined(Wireless_Stick_V3)
  #define RADIOLIB_EXCLUDE_SX127X (1)
  #define DISPLAY_GEOMETRY GEOMETRY_64_32
  #include LoRa32_HelTec_StickV3.h

#elif defined(Wireless_Stick_Lite)
  #define RADIOLIB_EXCLUDE_SX126X (1)
  #define HELTEC_NO_DISPLAY
  #include LoRa32_HelTec_StickLite.h
#elif defined(Wireless_Stick_Lite_V3)
  #define RADIOLIB_EXCLUDE_SX127X (1)
  #define HELTEC_NO_DISPLAY
  #include LoRa32_HelTec_StickLiteV3.h
#elif defined(Wireless_Tracker)
  #define RADIOLIB_EXCLUDE_SX126X (1)
  #define HELTEC_NO_DISPLAY
  #include LoRa32_HelTec_Tracker.h
#else
  #error "NO BOARD DEFINED!"
#endif

...

#ifndef HELTEC_NO_RADIO_INSTANCE
/*
 * @brief RadioLib build configuration options.
 *
 * RadioLib User Build Configuration Options. Used to define any user build options.
 */
  #ifndef HELTEC_NO_RADIOLIB

    ...

    /*
     * @brief Exclude RadioLib drivers to prevent collisions and to speed up build process.
     */
    #define RADIOLIB_EXCLUDE_CC1101           (1)
    #define RADIOLIB_EXCLUDE_NRF24            (1)
    #define RADIOLIB_EXCLUDE_RF69             (1)
    #define RADIOLIB_EXCLUDE_RFM2X            (1) // dependent on RADIOLIB_EXCLUDE_SI443X
    #define RADIOLIB_EXCLUDE_SI443X           (1)
    #define RADIOLIB_EXCLUDE_STM32WLX         (1) // dependent on RADIOLIB_EXCLUDE_SX126X
    #define RADIOLIB_EXCLUDE_SX1231           (1) // dependent on RADIOLIB_EXCLUDE_RF69
    #define RADIOLIB_EXCLUDE_SX128X           (1)
    
    /*
     * @brief Exclude RadioLib protocols to speed up build process.
     */
    #define RADIOLIB_EXCLUDE_AFSK             (1)
    #define RADIOLIB_EXCLUDE_APRS             (1)
    #define RADIOLIB_EXCLUDE_AX25             (1)
    #define RADIOLIB_EXCLUDE_BELL             (1)
    #define RADIOLIB_EXCLUDE_FSK4             (1)
    #define RADIOLIB_EXCLUDE_HELLSCHREIBER    (1)
    #define RADIOLIB_EXCLUDE_LORAWAN          (1)
    #define RADIOLIB_EXCLUDE_MORSE            (1)
    #define RADIOLIB_EXCLUDE_PAGER            (1)
    #define RADIOLIB_EXCLUDE_RTTY             (1)
    #define RADIOLIB_EXCLUDE_SSTV             (1)

    ...

    #if defined(RADIOLIB_EXCLUDE_SX126X)
      SX1276 radio = new Module(SS, DIO0, RST_LoRa, DIO1);
    #elif defined(RADIOLIB_EXCLUDE_SX127X)
      #if !defined(DIO0)
        #define DIO0 DIO1 // SX126x has no DIO0
      #endif
      #if !defined(DIO1)
        #define DIO1 DIO0 // SX126x has no DIO0
      #endif
      SX1262 radio = new Module(SS, DIO1, RST_LoRa, BUSY_LoRa);
    #endif
  #endif
#endif

I combined the HelTec and arduino-esp32 board definitions into own files which is not really needed (could also happen in one file) but i did it anyway.

Why are you not using the RadioLib build options to exclude all non used drivers? I would also disable all protocols and only enabled them if needed.

Why are you not using LED_BUILTIN but instead refer to the GPIO number? You should use the Arduino defined labels if possible.

This lib could easily be upgraded to include all LoRa32 devices (HelTec/lilygo)