Skip to content

Commit 89470f6

Browse files
committed
Abandon charls >2.0 (#953)
1 parent d3f3121 commit 89470f6

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

console/makefile

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -26,30 +26,9 @@ endif
2626

2727
#run "make" for default build
2828
#run "JPEGLS=1 make" for JPEGLS build
29-
#run "JPEGLS=2 make" for JPEGLS build with system CharLS
30-
# JPEGLS=0 : disable JPEG-LS
31-
# JPEGLS=1 : use local ./charls source files
32-
# JPEGLS=2 : use system-installed CharLS via pkg-config
33-
34-
ifeq ($(JPEGLS),1)
35-
CFLAGS += -DmyEnableJPEGLS
36-
CHARLS_SRCS = charls/jpegls.cpp charls/jpegmarkersegment.cpp charls/interface.cpp \
37-
charls/jpegstreamwriter.cpp charls/jpegstreamreader.cpp
38-
CFILES := $(CHARLS_SRCS) $(CFILES)
39-
endif
40-
41-
ifeq ($(JPEGLS),2)
42-
CFLAGS += -DmyEnableJPEGLS
43-
CHARLS_CFLAGS := $(shell pkg-config --cflags charls 2>/dev/null)
44-
CHARLS_LIBS := $(shell pkg-config --libs charls 2>/dev/null)
45-
ifeq ($(CHARLS_CFLAGS),)
46-
CHARLS_CFLAGS := -I/usr/include -I/opt/homebrew/include
47-
endif
48-
ifeq ($(CHARLS_LIBS),)
49-
CHARLS_LIBS := -lcharls -L/usr/lib -L/opt/homebrew/lib
50-
endif
51-
CFLAGS += $(CHARLS_CFLAGS)
52-
CFILES += $(CHARLS_LIBS)
29+
JFLAGS=
30+
ifeq "$(JPEGLS)" "1"
31+
JFLAGS=-std=c++14 -DmyEnableJPEGLS charls/jpegls.cpp charls/jpegmarkersegment.cpp charls/interface.cpp charls/jpegstreamwriter.cpp charls/jpegstreamreader.cpp
5332
endif
5433

5534
#run "JNIfTI=0 make" to disable JNIFTI build

console/nii_dicom_batch.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6883,7 +6883,7 @@ void sliceTimingXA(struct TDCMsort *dcmSort, struct TDICOMdata *dcmList, struct
68836883
return;
68846884
} else if (nConvert > hdr->dim[4]) {
68856885
// XA enhanced DICOM saves 1 file per 3D volume, classic DICOM saves multiple volumes
6886-
printWarning("4D Siemens XA images should be exported as enhanced not classic DICOM. Slice times and other properties may be inaccurate %d.\n");
6886+
printWarning("4D Siemens XA images should be exported as enhanced not classic DICOM. Slice times and other properties may be inaccurate.\n");
68876887
}
68886888
if ((nConvert == (hdr->dim[3] * hdr->dim[4])) && (hdr->dim[3] < (kMaxEPI3D - 1)) && (hdr->dim[3] > 1)) {
68896889
// issue875 use 2nd volume

0 commit comments

Comments
 (0)