Skip to content

Commit 949098a

Browse files
committed
Fix comments
1 parent aa929c6 commit 949098a

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

control_toolbox/include/control_toolbox/pid.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ class Pid
390390
tracking_time_constant parameter to tune the anti-windup behavior.
391391
* \return True if all parameters are successfully set, False otherwise.
392392
*
393-
* \note New gains are not applied if u_min > u_max.
393+
* \note New gains are not applied if i_min_ > i_max_ or u_min_ > u_max_.
394394
*/
395395
bool initialize(
396396
double p, double i, double d, double u_max, double u_min,
@@ -460,7 +460,7 @@ class Pid
460460
tracking_time_constant parameter to tune the anti-windup behavior.
461461
* \return True if all parameters are successfully set, False otherwise.
462462
*
463-
* \note New gains are not applied if u_min > u_max
463+
* \note New gains are not applied if i_min_ > i_max_ or u_min_ > u_max_.
464464
* \note This method is not RT safe
465465
*/
466466
bool set_gains(
@@ -469,11 +469,11 @@ class Pid
469469

470470
/*!
471471
* \brief Set PID gains for the controller.
472-
* \param gains A struct of the PID gain values
472+
* \param gains A struct of the PID gain values.
473473
* \return True if all parameters are successfully set, False otherwise.
474474
*
475-
* \note New gains are not applied if gains.i_min_ > gains.i_max_
476-
* \note This method is not RT safe
475+
* \note New gains are not applied if gains.i_min_ > gains.i_max_ or gains.u_min_ > gains.u_max_
476+
* \note This method is not RT safe.
477477
*/
478478
bool set_gains(const Gains & gains);
479479

@@ -483,7 +483,7 @@ class Pid
483483
* and the timestep \c dt_s.
484484
*
485485
* \param error Error since last call (error = target - state)
486-
* \param dt_s Change in time since last call in seconds
486+
* \param dt_s Change in time since last call in seconds.
487487
*
488488
* \returns PID command
489489
*/

control_toolbox/include/control_toolbox/pid_ros.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ class PidROS
169169
* \param save_i_term save integrator output between resets.
170170
* \return True if all parameters are successfully set, False otherwise.
171171
*
172-
* \note New gains are not applied if u_min_ > u_max_.
172+
* \note New gains are not applied if i_min_ > i_max_ or u_min_ > u_max_.
173173
*/
174174
bool initialize_from_args(
175175
double p, double i, double d, double u_max, double u_min,
@@ -242,7 +242,7 @@ class PidROS
242242
tracking_time_constant parameter to tune the anti-windup behavior.
243243
* \return True if all parameters are successfully set, False otherwise.
244244
*
245-
* \note New gains are not applied if u_min > u_max.
245+
* \note New gains are not applied if i_min_ > i_max_ or u_min_ > u_max_.
246246
* \note This method is not RT safe
247247
*/
248248
bool set_gains(

0 commit comments

Comments
 (0)