Use the new reusable helpers methods in hardware diagnostics (#2216)

saikishor · web-flow · commit 7317e4f2e035 · 2025-05-02T07:58:20.000+01:00
diff --git a/controller_manager/src/controller_manager.cpp b/controller_manager/src/controller_manager.cpp
@@ -3766,7 +3766,7 @@ void ControllerManager::hardware_components_diagnostic_callback(
                                                      .periodicity.standard_deviation.error)
           {
             diag_level = diagnostic_msgs::msg::DiagnosticStatus::ERROR;
-            add_element_to_list(bad_periodicity_async_hw, comp_name);
+            ros2_control::add_item(bad_periodicity_async_hw, comp_name);
           }
           else if (
             periodicity_error >
@@ -3778,7 +3778,7 @@ void ControllerManager::hardware_components_diagnostic_callback(
             {
               diag_level = diagnostic_msgs::msg::DiagnosticStatus::WARN;
             }
-            add_element_to_list(bad_periodicity_async_hw, comp_name);
+            ros2_control::add_item(bad_periodicity_async_hw, comp_name);
           }
         }
         const double max_exp_exec_time =

Original file line number	Diff line number	Diff line change
`@@ -3766,7 +3766,7 @@ void ControllerManager::hardware_components_diagnostic_callback(`
`3766`	`3766`	`.periodicity.standard_deviation.error)`
`3767`	`3767`	`{`
`3768`	`3768`	`diag_level = diagnostic_msgs::msg::DiagnosticStatus::ERROR;`
`3769`		`- add_element_to_list(bad_periodicity_async_hw, comp_name);`
	`3769`	`+ ros2_control::add_item(bad_periodicity_async_hw, comp_name);`
`3770`	`3770`	`}`
`3771`	`3771`	`else if (`
`3772`	`3772`	`periodicity_error >`
`@@ -3778,7 +3778,7 @@ void ControllerManager::hardware_components_diagnostic_callback(`
`3778`	`3778`	`{`
`3779`	`3779`	`diag_level = diagnostic_msgs::msg::DiagnosticStatus::WARN;`
`3780`	`3780`	`}`
`3781`		`- add_element_to_list(bad_periodicity_async_hw, comp_name);`
	`3781`	`+ ros2_control::add_item(bad_periodicity_async_hw, comp_name);`
`3782`	`3782`	`}`
`3783`	`3783`	`}`
`3784`	`3784`	`const double max_exp_exec_time =`