Skip to content

Commit 8f1f2bc

Browse files
authored
Fix docstring for hardware lifecycle (#2429) (#2430)
1 parent f4fbcb4 commit 8f1f2bc

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

hardware_interface/doc/hardware_components_userdoc.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ The hardware transitions to the following state after each method:
4141
* **INACTIVE** (``on_configure``, ``on_deactivate``):
4242

4343
Communication with the hardware is established and hardware component is configured.
44-
States can be read and command interfaces (System and Actuator only) are available.
44+
States can be read, but command interfaces (System and Actuator only) are not available.
4545

4646
As of now, it is left to the hardware component implementation to continue using the command received from the ``CommandInterfaces`` or to skip them completely.
4747

hardware_interface/include/hardware_interface/actuator_interface.hpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,15 @@ using CallbackReturn = rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface
6868
*
6969
* INACTIVE (on_configure, on_deactivate):
7070
* Communication with the hardware is started and it is configured.
71-
* States can be read and command interfaces are available.
72-
*
73-
* As of now, it is left to the hardware component implementation to continue using the command
74-
* received from the ``CommandInterfaces`` or to skip them completely.
71+
* States can be read, but command interfaces are not available.
7572
*
7673
* FINALIZED (on_shutdown):
7774
* Hardware interface is ready for unloading/destruction.
7875
* Allocated memory is cleaned up.
7976
*
8077
* ACTIVE (on_activate):
8178
* Power circuits of hardware are active and hardware can be moved, e.g., brakes are disabled.
82-
* Command interfaces available.
79+
* Command interfaces are available.
8380
*
8481
* \todo
8582
* Implement

hardware_interface/include/hardware_interface/system_interface.hpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,18 +72,15 @@ using CallbackReturn = rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface
7272
*
7373
* INACTIVE (on_configure, on_deactivate):
7474
* Communication with the hardware is started and it is configured.
75-
* States can be read and command interfaces are available.
76-
*
77-
* As of now, it is left to the hardware component implementation to continue using the command
78-
*received from the ``CommandInterfaces`` or to skip them completely.
75+
* States can be read, but command interfaces are not available.
7976
*
8077
* FINALIZED (on_shutdown):
8178
* Hardware interface is ready for unloading/destruction.
8279
* Allocated memory is cleaned up.
8380
*
8481
* ACTIVE (on_activate):
8582
* Power circuits of hardware are active and hardware can be moved, e.g., brakes are disabled.
86-
* Command interfaces available.
83+
* Command interfaces are available.
8784
*
8885
* \todo
8986
* Implement

0 commit comments

Comments
 (0)