Skip to content

Commit bc87596

Browse files
Merge branch 'humble' into mergify/bp/humble/pr-941
2 parents fef6d62 + a04eb5d commit bc87596

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

.github/workflows/reusable-ros-tooling-source-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
with:
3737
target-ros2-distro: ${{ inputs.ros_distro }}
3838
# build all packages listed in the meta package
39+
ref: ${{ inputs.ref }} # otherwise the default branch is used for scheduled workflows
3940
package-name:
4041
controller_interface
4142
controller_manager

.github/workflows/reviewer_lottery.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
jobs:
77
test:
88
runs-on: ubuntu-latest
9+
if: github.actor != 'dependabot[bot]' && github.actor != 'mergify[bot]'
910
steps:
1011
- uses: actions/checkout@v4
1112
- uses: uesteibar/reviewer-lottery@v3

controller_manager/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ if(BUILD_TESTING)
134134
controller_manager_msgs
135135
ros2_control_test_assets
136136
)
137+
set_tests_properties(test_controller_manager_srvs PROPERTIES TIMEOUT 120)
137138
ament_add_gmock(test_controller_manager_urdf_passing
138139
test/test_controller_manager_urdf_passing.cpp
139140
)

controller_manager/controller_manager/launch_utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ def generate_load_controller_launch_description(controller_name,
3232
Examples # noqa: D416
3333
--------
3434
# Assuming the controller type and controller parameters are known to the controller_manager
35-
generate_load_controller_launch_description('joint_state_controller')
35+
generate_load_controller_launch_description('joint_state_broadcaster')
3636
3737
# Passing controller type and controller parameter file to load
3838
generate_load_controller_launch_description(
39-
'joint_state_controller',
40-
controller_type='joint_state_controller/JointStateController',
39+
'joint_state_broadcaster',
40+
controller_type='joint_state_broadcaster/JointStateBroadcaster',
4141
controller_params_file=os.path.join(get_package_share_directory('my_pkg'),
4242
'config', 'controller_params.yaml')
4343
)

ros2controlcli/doc/userdoc.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ Example output:
7373
7474
$ ros2 control list_controller_types
7575
diff_drive_controller/DiffDriveController controller_interface::ControllerInterface
76-
joint_state_controller/JointStateController controller_interface::ControllerInterface
76+
joint_state_broadcaster/JointStateBroadcaster controller_interface::ControllerInterface
7777
joint_trajectory_controller/JointTrajectoryController controller_interface::ControllerInterface
7878
7979

0 commit comments

Comments
 (0)