Enable setting of initial state in HW compoments #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
aprotyas,
bmagyar,
jackcenter,
livanov93 and
malapatiravi
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 34.61% 32.34% -2.28%
==========================================
Files 52 93 +41
Lines 2981 9833 +6852
Branches 1855 6628 +4773
==========================================
+ Hits 1032 3180 +2148
- Misses 310 778 +468
- Partials 1639 5875 +4236
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
reviewed
Jun 21, 2023
bmagyar
reviewed
Jun 21, 2023
bmagyar
reviewed
Jun 21, 2023
Member
bmagyar
left a comment
bmagyar
left a comment
There was a problem hiding this comment.
THe only comment is regarding duplicating vs reworking the tests. Let's duplicate while the functionality is still there (we had issues with this before)
destogl
commented
Jun 22, 2023
bmagyar
reviewed
Jun 22, 2023
bmagyar
approved these changes
Jun 22, 2023
christophfroehlich
approved these changes
Jun 22, 2023
Contributor
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Sounds fine for me now
bmagyar
approved these changes
Jun 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
(cherry picked from commit cf4448d) # Conflicts: # controller_manager/src/controller_manager.cpp # hardware_interface/include/hardware_interface/resource_manager.hpp # hardware_interface/src/resource_manager.cpp
destogl
added a commit
that referenced
this pull request
Jan 22, 2024
) (cherry picked from commit cf4448d) --------- Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cleaned verison proposed in:
ros-controls/ros2_control_demos#277
Solves first part of #1045