Fix compatibility with SDL versions below 2.0.18 (#273)

meyerj · web-flow · commit a5adee5e1e99 · 2023-10-23T11:27:19.000-05:00
SDL_GameControllerHasRumble() was introduced in SDL 2.0.18 only (libsdl-org/SDL#4943). Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
diff --git a/joy/src/game_controller.cpp b/joy/src/game_controller.cpp
@@ -315,10 +315,14 @@ void GameController::handleControllerDeviceAdded(const SDL_ControllerDeviceEvent
     joy_msg_.axes.at(i) = convertRawAxisValueToROS(state);
   }
 
+#if SDL_VERSION_ATLEAST(2, 0, 18)
   const char * has_rumble_string = "No";
   if (SDL_GameControllerHasRumble(game_controller_)) {
     has_rumble_string = "Yes";
   }
+#else
+  const char * has_rumble_string = "Unknown";
+#endif
 
   RCLCPP_INFO(
     get_logger(), "Opened game controller: %s,  deadzone: %f, rumble: %s",

Original file line number	Diff line number	Diff line change
`@@ -315,10 +315,14 @@ void GameController::handleControllerDeviceAdded(const SDL_ControllerDeviceEvent`
`315`	`315`	`joy_msg_.axes.at(i) = convertRawAxisValueToROS(state);`
`316`	`316`	`}`
`317`	`317`
	`318`	`+#if SDL_VERSION_ATLEAST(2, 0, 18)`
`318`	`319`	`const char * has_rumble_string = "No";`
`319`	`320`	`if (SDL_GameControllerHasRumble(game_controller_)) {`
`320`	`321`	`has_rumble_string = "Yes";`
`321`	`322`	`}`
	`323`	`+#else`
	`324`	`+ const char * has_rumble_string = "Unknown";`
	`325`	`+#endif`
`322`	`326`
`323`	`327`	`RCLCPP_INFO(`
`324`	`328`	`get_logger(), "Opened game controller: %s, deadzone: %f, rumble: %s",`