Skip to content

Commit bea2d22

Browse files
fix linting problems Signed-off-by: suifengersan123 <[email protected]>
Signed-off-by: suifengersan123 <[email protected]>
1 parent cd0e5e6 commit bea2d22

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

nav2_dwb_controller/dwb_plugins/include/dwb_plugins/kinematic_parameters.hpp

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,13 +146,12 @@ class KinematicsHandler
146146
void deactivate();
147147

148148
inline KinematicParameters getKinematics() {
149-
KinematicParameters* ptr = kinematics_.load();
150-
// Check for nullptr before dereferencing
151-
if (ptr == nullptr) {
152-
throw std::runtime_error("Can't call KinematicsHandler::getKinematics()!");
153-
}
154-
return *ptr;
155-
}
149+
KinematicParameters* ptr = kinematics_.load();
150+
if (ptr == nullptr) {
151+
throw std::runtime_error("Can't call KinematicsHandler::getKinematics()!");
152+
}
153+
return *ptr;
154+
}
156155

157156
void setSpeedLimit(const double & speed_limit, const bool & percentage);
158157

nav2_dwb_controller/dwb_plugins/src/kinematic_parameters.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,11 @@ void KinematicsHandler::deactivate()
154154
void KinematicsHandler::setSpeedLimit(
155155
const double & speed_limit, const bool & percentage)
156156
{
157-
KinematicParameters* ptr = kinematics_.load();
158-
if (ptr == nullptr) {
159-
return; // Nothing to update
160-
}
161-
KinematicParameters kinematics(*ptr);
157+
KinematicParameters* ptr = kinematics_.load();
158+
if (ptr == nullptr) {
159+
return; // Nothing to update
160+
}
161+
KinematicParameters kinematics(*ptr);
162162

163163
if (speed_limit == nav2_costmap_2d::NO_SPEED_LIMIT) {
164164
// Restore default value
@@ -239,11 +239,11 @@ void
239239
KinematicsHandler::updateParametersCallback(std::vector<rclcpp::Parameter> parameters)
240240
{
241241
rcl_interfaces::msg::SetParametersResult result;
242-
KinematicParameters* ptr = kinematics_.load();
243-
if (ptr == nullptr) {
244-
return; // Nothing to update
245-
}
246-
KinematicParameters kinematics(*ptr);
242+
KinematicParameters* ptr = kinematics_.load();
243+
if (ptr == nullptr) {
244+
return; // Nothing to update
245+
}
246+
KinematicParameters kinematics(*ptr);
247247

248248
for (auto parameter : parameters) {
249249
const auto & param_type = parameter.get_type();

0 commit comments

Comments
 (0)