Deduplicate setup logic between this and ros-tooling/setup-ros

[emersonknapp]

The ROS 2 Installation logic is duplicated between this tool and https://github.com/ros-tooling/setup-ros/ - meaning whenever we need to tweak it we have to do it in two places. Deduplicate!

[flynneva]

@emersonknapp this script is much faster too compared to ros-tooling/setup-ros

[flynneva]

the only thing that I see is missing is the support for MacOS/Windows with this repo. I think with the other ros-tooling/setup_ros you could use it for Mac/Windows (might be broken, but not due to that repo).

[emersonknapp]

Yeah - I don't think that you can run windows containers on Action runners (I might be wrong) - and as far as I know there is no such thing as a "osx container". So, like you said, we would need to continue using the action-based setup for those platforms, rather than jumpstarting from an image like we do with setup-ros-docker

[kenji-miyake]

As for installing packages, I think parsing setup-ros source code and generating requirements.txt is a good way.
kenji-miyake#7

(How to change setup-ros-docker to use requirements.txt is written here.)
#41 (comment)

Currently, it only supports pip3 packages, but it can easily be extended to apt packages as well.

With this, I believe it will be easier to make docker images that have corresponding versions to setup-ros.
This discussion is held here.
#41 (comment)

@emersonknapp @christophebedard How do you feel about it?

[christophebedard]

@kenji-miyake that's an interesting approach! I know @emersonknapp was working on some tooling to manage common config files across ros-tooling repos: https://github.com/ros-tooling/repo-configs. Not sure if he wanted to use it to manage the requirements.txt files.

[emersonknapp]

I don't think it makes sense to use repo-configs to manage this thing. That mechanism is intended for common configuration of the repositories themselves ("github stuff"), and probably shouldn't touch any business logic. It makes more sense to me, to set up a dependency between setup-ros and setup-ros-docker so that one consumes information from the other.