Skip to content

Commit 0138e33

Browse files
committed
Update doctests
Signed-off-by: Michael X. Grey <[email protected]>
1 parent 5c59592 commit 0138e33

File tree

3 files changed

+64
-66
lines changed

3 files changed

+64
-66
lines changed

rclrs/src/context.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ impl Context {
104104
///
105105
/// # Example
106106
/// ```
107-
/// use rclrs::{Context, InitOptions};
107+
/// # use rclrs::{Context, InitOptions};
108108
/// let context = Context::new_with_options([], InitOptions::new().with_domain_id(Some(5))).unwrap();
109109
/// assert_eq!(context.domain_id(), 5);
110110
/// ````

rclrs/src/node.rs

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
mod options;
2-
pub use options::*;
1+
mod node_options;
2+
pub use node_options::*;
33

44
mod graph;
55
pub use graph::*;
@@ -128,13 +128,13 @@ impl Node {
128128
/// ```
129129
/// # use rclrs::{Context, RclrsError};
130130
/// // Without remapping
131-
/// let context = Context::new([])?;
132-
/// let node = rclrs::create_node(&context, "my_node")?;
131+
/// let executor = Context::default().create_basic_executor();
132+
/// let node = executor.create_node("my_node")?;
133133
/// assert_eq!(node.name(), "my_node");
134134
/// // With remapping
135135
/// let remapping = ["--ros-args", "-r", "__node:=your_node"].map(String::from);
136-
/// let context_r = Context::new(remapping)?;
137-
/// let node_r = rclrs::create_node(&context_r, "my_node")?;
136+
/// let executor_r = Context::new(remapping)?.create_basic_executor();
137+
/// let node_r = executor_r.create_node("my_node")?;
138138
/// assert_eq!(node_r.name(), "your_node");
139139
/// # Ok::<(), RclrsError>(())
140140
/// ```
@@ -149,18 +149,18 @@ impl Node {
149149
///
150150
/// # Example
151151
/// ```
152-
/// # use rclrs::{Context, RclrsError};
152+
/// # use rclrs::{Context, RclrsError, NodeOptions};
153153
/// // Without remapping
154-
/// let context = Context::new([])?;
155-
/// let node =
156-
/// rclrs::create_node_builder(&context, "my_node")
157-
/// .namespace("/my/namespace")
158-
/// .build()?;
154+
/// let executor = Context::default().create_basic_executor();
155+
/// let node = executor.create_node(
156+
/// NodeOptions::new("my_node")
157+
/// .namespace("/my/namespace")
158+
/// )?;
159159
/// assert_eq!(node.namespace(), "/my/namespace");
160160
/// // With remapping
161161
/// let remapping = ["--ros-args", "-r", "__ns:=/your_namespace"].map(String::from);
162-
/// let context_r = Context::new(remapping)?;
163-
/// let node_r = rclrs::create_node(&context_r, "my_node")?;
162+
/// let executor_r = Context::new(remapping)?.create_basic_executor();
163+
/// let node_r = executor_r.create_node("my_node")?;
164164
/// assert_eq!(node_r.namespace(), "/your_namespace");
165165
/// # Ok::<(), RclrsError>(())
166166
/// ```
@@ -175,12 +175,12 @@ impl Node {
175175
///
176176
/// # Example
177177
/// ```
178-
/// # use rclrs::{Context, RclrsError};
179-
/// let context = Context::new([])?;
180-
/// let node =
181-
/// rclrs::create_node_builder(&context, "my_node")
182-
/// .namespace("/my/namespace")
183-
/// .build()?;
178+
/// # use rclrs::{Context, RclrsError, NodeOptions};
179+
/// let executor = Context::default().create_basic_executor();
180+
/// let node = executor.create_node(
181+
/// NodeOptions::new("my_node")
182+
/// .namespace("/my/namespace")
183+
/// )?;
184184
/// assert_eq!(node.fully_qualified_name(), "/my/namespace/my_node");
185185
/// # Ok::<(), RclrsError>(())
186186
/// ```
@@ -353,8 +353,8 @@ impl Node {
353353
/// # use rclrs::{Context, RclrsError};
354354
/// // Set default ROS domain ID to 10 here
355355
/// std::env::set_var("ROS_DOMAIN_ID", "10");
356-
/// let context = Context::new([])?;
357-
/// let node = rclrs::create_node(&context, "domain_id_node")?;
356+
/// let executor = Context::default().create_basic_executor();
357+
/// let node = executor.create_node("domain_id_node")?;
358358
/// let domain_id = node.domain_id();
359359
/// assert_eq!(domain_id, 10);
360360
/// # Ok::<(), RclrsError>(())
@@ -382,8 +382,8 @@ impl Node {
382382
/// # Example
383383
/// ```
384384
/// # use rclrs::{Context, ParameterRange, RclrsError};
385-
/// let context = Context::new([])?;
386-
/// let node = rclrs::create_node(&context, "domain_id_node")?;
385+
/// let executor = Context::default().create_basic_executor();
386+
/// let node = executor.create_node("domain_id_node")?;
387387
/// // Set it to a range of 0-100, with a step of 2
388388
/// let range = ParameterRange {
389389
/// lower: Some(0),

rclrs/src/node/options.rs renamed to rclrs/src/node/node_options.rs

Lines changed: 39 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,19 @@ use crate::{
2828
///
2929
/// # Example
3030
/// ```
31-
/// # use rclrs::{Context, NodeBuilder, Node, RclrsError};
32-
/// let context = Context::new([])?;
31+
/// # use rclrs::{Context, NodeOptions, Node, RclrsError};
32+
/// let executor = Context::default().create_basic_executor();
3333
/// // Building a node in a single expression
34-
/// let node = NodeBuilder::new(&context, "foo_node").namespace("/bar").build()?;
34+
/// let node = executor.create_node(NodeOptions::new("foo_node").namespace("/bar"))?;
3535
/// assert_eq!(node.name(), "foo_node");
3636
/// assert_eq!(node.namespace(), "/bar");
37-
/// // Building a node via Node::builder()
38-
/// let node = Node::builder(&context, "bar_node").build()?;
37+
/// // Building a node via NodeOptions
38+
/// let node = executor.create_node(NodeOptions::new("bar_node"))?;
3939
/// assert_eq!(node.name(), "bar_node");
4040
/// // Building a node step-by-step
41-
/// let mut builder = Node::builder(&context, "goose");
42-
/// builder = builder.namespace("/duck/duck");
43-
/// let node = builder.build()?;
41+
/// let mut options = NodeOptions::new("goose");
42+
/// options = options.namespace("/duck/duck");
43+
/// let node = executor.create_node(options)?;
4444
/// assert_eq!(node.fully_qualified_name(), "/duck/duck/goose");
4545
/// # Ok::<(), RclrsError>(())
4646
/// ```
@@ -75,17 +75,15 @@ impl NodeOptions {
7575
///
7676
/// # Example
7777
/// ```
78-
/// # use rclrs::{Context, NodeOptions};
79-
/// let context = Context::new();
78+
/// # use rclrs::{Context, NodeOptions, RclrsError, RclReturnCode};
79+
/// let executor = Context::default().create_basic_executor();
8080
/// // This is a valid node name
81-
/// assert!(NodeOptions::new("my_node").is_valid());
81+
/// assert!(executor.create_node(NodeOptions::new("my_node")).is_ok());
8282
/// // This is another valid node name (although not a good one)
83-
/// assert!(NodeBuilder::new(&context, "_______").build().is_ok());
83+
/// assert!(executor.create_node(NodeOptions::new("_______")).is_ok());
8484
/// // This is an invalid node name
8585
/// assert!(matches!(
86-
/// NodeBuilder::new(&context, "röböt")
87-
/// .build()
88-
/// .unwrap_err(),
86+
/// executor.create_node(NodeOptions::new("röböt")).unwrap_err(),
8987
/// RclrsError::RclError { code: RclReturnCode::NodeInvalidName, .. }
9088
/// ));
9189
/// # Ok::<(), RclrsError>(())
@@ -128,25 +126,25 @@ impl NodeOptions {
128126
///
129127
/// # Example
130128
/// ```
131-
/// # use rclrs::{Context, Node, RclrsError, RclReturnCode};
132-
/// let context = Context::new([])?;
129+
/// # use rclrs::{Context, Node, NodeOptions, RclrsError, RclReturnCode};
130+
/// let executor = Context::default().create_basic_executor();
133131
/// // This is a valid namespace
134-
/// let builder_ok_ns = Node::builder(&context, "my_node").namespace("/some/nested/namespace");
135-
/// assert!(builder_ok_ns.build().is_ok());
132+
/// let options_ok_ns = NodeOptions::new("my_node").namespace("/some/nested/namespace");
133+
/// assert!(executor.create_node(options_ok_ns).is_ok());
136134
/// // This is an invalid namespace
137135
/// assert!(matches!(
138-
/// Node::builder(&context, "my_node")
136+
/// executor.create_node(
137+
/// NodeOptions::new("my_node")
139138
/// .namespace("/10_percent_luck/20_percent_skill")
140-
/// .build()
141-
/// .unwrap_err(),
139+
/// ).unwrap_err(),
142140
/// RclrsError::RclError { code: RclReturnCode::NodeInvalidNamespace, .. }
143141
/// ));
144142
/// // A missing forward slash at the beginning is automatically added
145143
/// assert_eq!(
146-
/// Node::builder(&context, "my_node")
144+
/// executor.create_node(
145+
/// NodeOptions::new("my_node")
147146
/// .namespace("foo")
148-
/// .build()?
149-
/// .namespace(),
147+
/// )?.namespace(),
150148
/// "/foo"
151149
/// );
152150
/// # Ok::<(), RclrsError>(())
@@ -167,21 +165,21 @@ impl NodeOptions {
167165
///
168166
/// # Example
169167
/// ```
170-
/// # use rclrs::{Context, Node, NodeBuilder, RclrsError};
168+
/// # use rclrs::{Context, Node, NodeOptions, RclrsError};
171169
/// let context_args = ["--ros-args", "--remap", "__node:=your_node"]
172170
/// .map(String::from);
173-
/// let context = Context::new(context_args)?;
171+
/// let executor = Context::new(context_args)?.create_basic_executor();
174172
/// // Ignore the global arguments:
175-
/// let node_without_global_args =
176-
/// rclrs::create_node_builder(&context, "my_node")
177-
/// .use_global_arguments(false)
178-
/// .build()?;
173+
/// let node_without_global_args = executor.create_node(
174+
/// NodeOptions::new("my_node")
175+
/// .use_global_arguments(false)
176+
/// )?;
179177
/// assert_eq!(node_without_global_args.name(), "my_node");
180178
/// // Do not ignore the global arguments:
181-
/// let node_with_global_args =
182-
/// rclrs::create_node_builder(&context, "my_other_node")
183-
/// .use_global_arguments(true)
184-
/// .build()?;
179+
/// let node_with_global_args = executor.create_node(
180+
/// NodeOptions::new("my_other_node")
181+
/// .use_global_arguments(true)
182+
/// )?;
185183
/// assert_eq!(node_with_global_args.name(), "your_node");
186184
/// # Ok::<(), RclrsError>(())
187185
/// ```
@@ -202,18 +200,18 @@ impl NodeOptions {
202200
///
203201
/// # Example
204202
/// ```
205-
/// # use rclrs::{Context, Node, NodeBuilder, RclrsError};
203+
/// # use rclrs::{Context, Node, NodeOptions, RclrsError};
206204
/// // Usually, this would change the name of "my_node" to "context_args_node":
207205
/// let context_args = ["--ros-args", "--remap", "my_node:__node:=context_args_node"]
208206
/// .map(String::from);
209-
/// let context = Context::new(context_args)?;
207+
/// let executor = Context::new(context_args)?.create_basic_executor();
210208
/// // But the node arguments will change it to "node_args_node":
211209
/// let node_args = ["--ros-args", "--remap", "my_node:__node:=node_args_node"]
212210
/// .map(String::from);
213-
/// let node =
214-
/// rclrs::create_node_builder(&context, "my_node")
215-
/// .arguments(node_args)
216-
/// .build()?;
211+
/// let node = executor.create_node(
212+
/// NodeOptions::new("my_node")
213+
/// .arguments(node_args)
214+
/// )?;
217215
/// assert_eq!(node.name(), "node_args_node");
218216
/// # Ok::<(), RclrsError>(())
219217
/// ```

0 commit comments

Comments
 (0)