Clear warnings

Signed-off-by: Luca Della Vedova <[email protected]>

Author: luca-della-vedova

rclrs/src/dynamic_message/dynamic_subscription.rs

@@ -242,6 +242,8 @@ where
     ///
     /// Holding onto this sender will keep the subscription task alive. Once
     /// this sender is dropped, the subscription task will end itself.
+    // TODO(luca) Expose an API to update the callback at runtime
+    #[allow(unused)]
     callback: Arc<Mutex<DynamicSubscriptionCallback<Scope::Payload>>>,
     /// Holding onto this keeps the waiter for this subscription alive in the
     /// wait set of the executor.
@@ -267,7 +269,6 @@ where
         node_handle: &Arc<NodeHandle>,
         commands: &Arc<WorkerCommands>,
     ) -> Result<Arc<Self>, RclrsError> {
-        // TODO(luca) a lot of duplication with nomral, refactor
         // This loads the introspection type support library.
         let metadata = DynamicMessageMetadata::new(topic_type)?;
         let SubscriptionOptions { topic, qos } = options.into();

rclrs/src/node.rs

@@ -6,15 +6,19 @@ pub use primitive_options::*;
 
 mod graph;
 #[cfg(feature = "dyn_msg")]
-use crate::dynamic_message::{
-    DynamicMessage, DynamicPublisher, DynamicPublisherState, DynamicSubscription,
-    DynamicSubscriptionState, MessageTypeName, NodeAsyncDynamicSubscriptionCallback,
-    NodeDynamicSubscriptionCallback,
+use crate::{
+    dynamic_message::{
+        DynamicMessage, DynamicPublisher, DynamicPublisherState, DynamicSubscription,
+        DynamicSubscriptionState, MessageTypeName, NodeAsyncDynamicSubscriptionCallback,
+        NodeDynamicSubscriptionCallback,
+    },
+    MessageInfo,
 };
+#[cfg(feature = "dyn_msg")]
+use futures::future::BoxFuture;
 
 pub use graph::*;
 
-use futures::future::BoxFuture;
 mod node_graph_task;
 use node_graph_task::*;
 
@@ -39,11 +43,10 @@ use rosidl_runtime_rs::Message;
 use crate::{
     rcl_bindings::*, Client, ClientOptions, ClientState, Clock, ContextHandle, ExecutorCommands,
     IntoAsyncServiceCallback, IntoAsyncSubscriptionCallback, IntoNodeServiceCallback,
-    IntoNodeSubscriptionCallback, LogParams, Logger, MessageInfo, ParameterBuilder,
-    ParameterInterface, ParameterVariant, Parameters, Promise, Publisher, PublisherOptions,
-    PublisherState, RclrsError, Service, ServiceOptions, ServiceState, Subscription,
-    SubscriptionOptions, SubscriptionState, TimeSource, ToLogParams, Worker, WorkerOptions,
-    WorkerState, ENTITY_LIFECYCLE_MUTEX,
+    IntoNodeSubscriptionCallback, LogParams, Logger, ParameterBuilder, ParameterInterface,
+    ParameterVariant, Parameters, Promise, Publisher, PublisherOptions, PublisherState, RclrsError,
+    Service, ServiceOptions, ServiceState, Subscription, SubscriptionOptions, SubscriptionState,
+    TimeSource, ToLogParams, Worker, WorkerOptions, WorkerState, ENTITY_LIFECYCLE_MUTEX,
 };
 
 /// A processing unit that can communicate with other nodes. See the API of

rclrs/src/worker.rs

@@ -1,11 +1,14 @@
 #[cfg(feature = "dyn_msg")]
-use crate::dynamic_message::{
-    DynamicMessage, DynamicSubscriptionState, MessageTypeName, WorkerDynamicSubscription,
-    WorkerDynamicSubscriptionCallback,
+use crate::{
+    dynamic_message::{
+        DynamicMessage, DynamicSubscriptionState, MessageTypeName, WorkerDynamicSubscription,
+        WorkerDynamicSubscriptionCallback,
+    },
+    MessageInfo,
 };
 use crate::{
-    log_fatal, IntoWorkerServiceCallback, IntoWorkerSubscriptionCallback, MessageInfo, Node,
-    Promise, RclrsError, ServiceOptions, ServiceState, SubscriptionOptions, SubscriptionState,
+    log_fatal, IntoWorkerServiceCallback, IntoWorkerSubscriptionCallback, Node, Promise,
+    RclrsError, ServiceOptions, ServiceState, SubscriptionOptions, SubscriptionState,
     WorkerCommands, WorkerService, WorkerSubscription,
 };
 use futures::channel::oneshot;