Rename to avoid confusion with Handle pattern

Signed-off-by: Michael X. Grey <[email protected]>

Author: mxgrey

rclrs/src/node.rs

@@ -194,7 +194,7 @@ impl Node {
         getter: unsafe extern "C" fn(*const rcl_node_t) -> *const c_char,
     ) -> String {
         let rcl_node = self.handle.rcl_node.lock().unwrap();
-        unsafe { call_string_getter_with_handle(&rcl_node, getter) }
+        unsafe { call_string_getter_with_rcl_node(&rcl_node, getter) }
     }
 
     /// Creates a [`Client`][1].
@@ -446,7 +446,7 @@ impl Node {
 // function, which is why it's not merged into Node::call_string_getter().
 // This function is unsafe since it's possible to pass in an rcl_node_t with dangling
 // pointers etc.
-pub(crate) unsafe fn call_string_getter_with_handle(
+pub(crate) unsafe fn call_string_getter_with_rcl_node(
     rcl_node: &rcl_node_t,
     getter: unsafe extern "C" fn(*const rcl_node_t) -> *const c_char,
 ) -> String {

rclrs/src/parameter.rs

@@ -5,7 +5,7 @@ pub(crate) use override_map::*;
 pub use value::*;
 
 use crate::rcl_bindings::*;
-use crate::{call_string_getter_with_handle, RclrsError};
+use crate::{call_string_getter_with_rcl_node, RclrsError};
 use std::collections::{btree_map::Entry, BTreeMap};
 use std::fmt::Debug;
 use std::marker::PhantomData;
@@ -781,7 +781,7 @@ impl ParameterInterface {
         global_arguments: &rcl_arguments_t,
     ) -> Result<Self, RclrsError> {
         let override_map = unsafe {
-            let fqn = call_string_getter_with_handle(rcl_node, rcl_node_get_fully_qualified_name);
+            let fqn = call_string_getter_with_rcl_node(rcl_node, rcl_node_get_fully_qualified_name);
             resolve_parameter_overrides(&fqn, node_arguments, global_arguments)?
         };