Error handling

Author: GueLaKais

rosidl_runtime_rs/src/sequence.rs

@@ -338,7 +338,7 @@ impl<T: SequenceAlloc + Clone, const N: usize> TryFrom<&[T]> for BoundedSequence
 impl<T: SequenceAlloc, const N: usize> TryFrom<Vec<T>> for BoundedSequence<T, N> {
     type Error = SequenceExceedsBoundsError;
     fn try_from(v: Vec<T>) -> Result<Self, Self::Error> {
-        match v.len() {
+        match v.len() > N {
             true => Err(SequenceExceedsBoundsError {
                 len: v.len(),
                 upper_bound: N,
@@ -541,7 +541,6 @@ impl std::error::Error for SequenceExceedsBoundsError {}
 /// * `$copy_func:ident` - The name of the extern "C" function used to copy a sequence.
 macro_rules! impl_sequence_alloc_for_primitive_type {
     ($rust_type:ty, $init_func:ident, $fini_func:ident, $copy_func:ident) => {
-        /// Provides default implementations for SequenceAlloc for primitive types.
         #[link(name = "rosidl_runtime_c")]
         extern "C" {
             fn $init_func(seq: *mut Sequence<$rust_type>, size: usize) -> bool;
@@ -555,12 +554,13 @@ macro_rules! impl_sequence_alloc_for_primitive_type {
         impl SequenceAlloc for $rust_type {
             fn sequence_init(seq: &mut Sequence<Self>, size: usize) -> bool {
                 // SAFETY: There are no special preconditions to the sequence_init function.
+
                 unsafe {
-                    match seq.data.is_null(){
-                        // This allocates space and sets seq.size and seq.capacity to size
-                        true => $init_func(seq as *mut _, size),
-                        _ => std::ptr::write_bytes(seq.data, 0u8, size);
+                    if !seq.data.is_null() {
+                        // Zero memory, since it will be uninitialized if there is no default value
+                        std::ptr::write_bytes(seq.data, 0u8, size);
                     }
+                    $init_func(seq as *mut _, size)
                 }
             }
             fn sequence_fini(seq: &mut Sequence<Self>) {