use GITHUB_WORKSPACE instead of hardcoded dir winCI #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-della-vedova
approved these changes
Jun 17, 2025
esteve
approved these changes
Jun 17, 2025
Collaborator
esteve
left a comment
esteve
left a comment
There was a problem hiding this comment.
@knmcguire LGTM, thanks!
Contributor
Author
|
Awesome! I have no more additions and it shouldn't conflict the other PR i'm working on, so feel free to merge at your convinience |
Collaborator
|
CI has passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows CI is failing and that is due to this line right here:
ros2_rust/.github/workflows/rust-win.yml
Line 29 in d62583d
Apparently this directory changed from D:/ to C:/ when it got merged into main. Why? no idea! But now it should use the GITHUB_WORKSPACE directory instead of hardcoding it, so it should should be more generic at least.
I've put it into draft until it builds.