fix: let user pass compiler flag to specify the ROS distro #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
jhdcs
reviewed
Aug 20, 2025
| @@ -43,10 +43,9 @@ tempfile = "3.3.0" | |||
| tokio = { version = "1", features = ["rt", "time", "macros"] } | |||
|
|
|||
| [build-dependencies] | |||
| # Needed for FFI | |||
| bindgen = "0.70" | |||
There was a problem hiding this comment.
Is there a reason bindgen was removed?
There was a problem hiding this comment.
It's not used anymore, the bindings are generated via the generate_binding.py script, which invokes the bindgen binary.
maspe36
approved these changes
Aug 20, 2025
|
@maspe36 thanks for the approval. Let's hope this time it works and release-plz can push rclrs to crates.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets the user set the target ROS distro via
RUSTFLAGS = --cfg ros_distro="<ros_distro>"This also fixes an issue in the release-plz job that prevented it from building the crate before being published to crates.io