Draft: Derive macro for StructuredParameters #516
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCSol
commented
Aug 19, 2025
Comment on lines
+22
to
+25
| <depend>rosidl_default_generators</depend> | ||
|
|
||
| <test_depend>test_msgs</test_depend> | ||
| <test_depend>example_interfaces</test_depend> | ||
| <depend>test_msgs</depend> | ||
| <depend>example_interfaces</depend> |
There was a problem hiding this comment.
these are tinkering steps to resolve cargo build without colcon.
I'll remove these
BCSol
commented
Aug 19, 2025
Comment on lines
+12
to
+13
| ros-humble-test-msgs \ | ||
| ros-humble-example-interfaces \ |
There was a problem hiding this comment.
I was unable to build with cargo without these changes.
With colcon everything was working fine.
These can probably be reverted, but then development with rust-analyzer doesn't really work
There was a problem hiding this comment.
I only ran into this issue after adding the crate rclrs_proc_macros and enabling proc-macro=True in the cargo config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for structured parameters derive macro (#496)
Changes:
StructuredParametersrclrs_proc_macrostest_msgsandexample_messageswith apt, without the cargo build without colon would fail to link rosidl message (I'd be happy about some help there)TODO:
NodeState/Node@mxgrey before I continue here, I'd be happy about some feedback, whether this is what you had in mind or how we could improve upon this POC.