Skip to content

Commit 2311918

Browse files
authored
Fix clang build warnings. (#628)
For Ubuntu 22.04, we disabled some warnings with GCC specifically for arm64. However, those flags are not supported on clang, and further clang defines __GNU__ when compiling. Add in an additional check for being on clang so we avoid a clang warning. Signed-off-by: Chris Lalancette <[email protected]>
1 parent 8706e81 commit 2311918

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

tf2_eigen/test/tf2_eigen-test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@
4343
// https://salsa.debian.org/science-team/eigen3/-/merge_requests/1 .
4444
// However, it is not clear that that fix is going to make it into Ubuntu 22.04 before it
4545
// freezes, so disable the warning here.
46-
#ifdef __GNUC__
46+
#if defined(__GNUC__) && !defined(__clang__)
4747
#pragma GCC diagnostic push
4848
#pragma GCC diagnostic ignored "-Wclass-memaccess"
4949
#endif
5050
#include <Eigen/Geometry> // NOLINT
51-
#ifdef __GNUC__
51+
#if defined(__GNUC__) && !defined(__clang__)
5252
#pragma GCC diagnostic pop
5353
#endif
5454

tf2_eigen_kdl/include/tf2_eigen_kdl/tf2_eigen_kdl.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,13 @@
4343
// https://salsa.debian.org/science-team/eigen3/-/merge_requests/1 .
4444
// However, it is not clear that that fix is going to make it into Ubuntu 22.04 before it
4545
// freezes, so disable the warning here.
46-
#ifdef __GNUC__
46+
#if defined(__GNUC__) && !defined(__clang__)
4747
#pragma GCC diagnostic push
4848
#pragma GCC diagnostic ignored "-Wclass-memaccess"
4949
#endif
5050
#include <Eigen/Core>
5151
#include <Eigen/Geometry>
52-
#ifdef __GNUC__
52+
#if defined(__GNUC__) && !defined(__clang__)
5353
#pragma GCC diagnostic pop
5454
#endif
5555

tf2_sensor_msgs/include/tf2_sensor_msgs/tf2_sensor_msgs.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@
3737
// https://salsa.debian.org/science-team/eigen3/-/merge_requests/1 .
3838
// However, it is not clear that that fix is going to make it into Ubuntu 22.04 before it
3939
// freezes, so disable the warning here.
40-
#ifdef __GNUC__
40+
#if defined(__GNUC__) && !defined(__clang__)
4141
#pragma GCC diagnostic push
4242
#pragma GCC diagnostic ignored "-Wclass-memaccess"
4343
#endif
4444
#include <Eigen/Eigen> // NOLINT
4545
#include <Eigen/Geometry> // NOLINT
46-
#ifdef __GNUC__
46+
#if defined(__GNUC__) && !defined(__clang__)
4747
#pragma GCC diagnostic pop
4848
#endif
4949

0 commit comments

Comments
 (0)