Skip to content

Commit 3951ce6

Browse files
committed
Re-enable unstamped eigen tests
they were disabled because of MSVC and ADL (MSVC couldn't choose between tf2::toMsg and Eigen::toMsg)
1 parent a9b6d67 commit 3951ce6

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

tf2_eigen/test/tf2_eigen-test.cpp

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,17 @@ TEST(TfEigen, ConvertVector3dStamped)
6565
EXPECT_EQ(v, v1);
6666
}
6767

68-
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
69-
// TEST(TfEigen, ConvertVector3d)
70-
// {
71-
// const Eigen::Vector3d v(1,2,3);
68+
TEST(TfEigen, ConvertVector3d)
69+
{
70+
const Eigen::Vector3d v(1, 2, 3);
7271

73-
// Eigen::Vector3d v1;
74-
// geometry_msgs::msg::Point p1;
75-
// tf2::convert(v, p1);
76-
// tf2::convert(p1, v1);
72+
Eigen::Vector3d v1;
73+
geometry_msgs::msg::Point p1;
74+
tf2::convert(v, p1);
75+
tf2::convert(p1, v1);
7776

78-
// EXPECT_EQ(v, v1);
79-
// }
77+
EXPECT_EQ(v, v1);
78+
}
8079

8180
TEST(TfEigen, ConvertAffine3dStamped)
8281
{
@@ -98,20 +97,20 @@ TEST(TfEigen, ConvertAffine3dStamped)
9897
EXPECT_EQ(v.stamp_, v1.stamp_);
9998
}
10099

101-
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
102-
// TEST(TfEigen, ConvertAffine3d)
103-
// {
104-
// const Eigen::Affine3d v(
105-
// Eigen::Translation3d(1,2,3) * Eigen::AngleAxis<double>(1, Eigen::Vector3d::UnitX()));
100+
TEST(TfEigen, ConvertAffine3d)
101+
{
102+
const Eigen::Affine3d v(Eigen::Translation3d(1, 2, 3) * Eigen::AngleAxis<double>(
103+
1,
104+
Eigen::Vector3d::UnitX()));
106105

107-
// Eigen::Affine3d v1;
108-
// geometry_msgs::msg::Pose p1;
109-
// tf2::convert(v, p1);
110-
// tf2::convert(p1, v1);
106+
Eigen::Affine3d v1;
107+
geometry_msgs::msg::Pose p1;
108+
tf2::convert(v, p1);
109+
tf2::convert(p1, v1);
111110

112-
// EXPECT_EQ(v.translation(), v1.translation());
113-
// EXPECT_EQ(v.rotation(), v1.rotation());
114-
// }
111+
EXPECT_EQ(v.translation(), v1.translation());
112+
EXPECT_EQ(v.rotation(), v1.rotation());
113+
}
115114

116115
TEST(TfEigen, ConvertTransform)
117116
{

0 commit comments

Comments
 (0)