Skip to content

Commit 45fd4e6

Browse files
gleichdickahcorde
andauthored
Reenable stamped eigen tests (#429)
* Reenable stamped eigen tests Co-authored-by: Bjar Ne <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
1 parent e9da371 commit 45fd4e6

File tree

2 files changed

+38
-28
lines changed

2 files changed

+38
-28
lines changed

tf2_eigen/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,6 @@ ament_export_include_directories(include)
4949
ament_export_dependencies(
5050
eigen3_cmake_module
5151
Eigen3
52+
tf2
5253
tf2_ros)
5354
ament_package()

tf2_eigen/test/tf2_eigen-test.cpp

Lines changed: 37 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,37 @@
3535
#endif
3636

3737
#include <gtest/gtest.h>
38+
#include <geometry_msgs/msg/point.hpp>
39+
#include <geometry_msgs/msg/point_stamped.hpp>
40+
#include <geometry_msgs/msg/pose.hpp>
41+
#include <geometry_msgs/msg/pose_stamped.hpp>
42+
#include <geometry_msgs/msg/transform_stamped.hpp>
3843
#include <rclcpp/clock.hpp>
3944
#include <tf2/convert.h>
45+
#include <tf2/transform_datatypes.h>
4046
#include <tf2_eigen/tf2_eigen.hpp>
4147
#include <tf2_ros/buffer.h>
4248
#include <tf2_ros/transform_listener.h>
4349

50+
#include <Eigen/Geometry>
51+
4452
#include <cmath>
4553
#include <memory>
4654

47-
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
48-
// TEST(TfEigen, ConvertVector3dStamped)
49-
// {
50-
// const tf2::Stamped<Eigen::Vector3d> v(Eigen::Vector3d(1,2,3),
51-
// tf2::TimePoint(std::chrono::seconds(5)), "test");
55+
TEST(TfEigen, ConvertVector3dStamped)
56+
{
57+
const tf2::Stamped<Eigen::Vector3d> v(Eigen::Vector3d(1, 2, 3), tf2::TimePoint(
58+
std::chrono::seconds(5)), "test");
5259

53-
// tf2::Stamped<Eigen::Vector3d> v1;
54-
// geometry_msgs::msg::PointStamped p1;
55-
// tf2::convert(v, p1);
56-
// tf2::convert(p1, v1);
60+
tf2::Stamped<Eigen::Vector3d> v1;
61+
geometry_msgs::msg::PointStamped p1;
62+
tf2::convert(v, p1);
63+
tf2::convert(p1, v1);
5764

58-
// EXPECT_EQ(v, v1);
59-
// }
65+
EXPECT_EQ(v, v1);
66+
}
6067

68+
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
6169
// TEST(TfEigen, ConvertVector3d)
6270
// {
6371
// const Eigen::Vector3d v(1,2,3);
@@ -70,24 +78,25 @@
7078
// EXPECT_EQ(v, v1);
7179
// }
7280

73-
// TEST(TfEigen, ConvertAffine3dStamped)
74-
// {
75-
// const Eigen::Affine3d v_nonstamped(
76-
// Eigen::Translation3d(1,2,3) * Eigen::AngleAxis<double>(1, Eigen::Vector3d::UnitX()));
77-
// const tf2::Stamped<Eigen::Affine3d> v(
78-
// v_nonstamped, tf2::TimePoint(std::chrono::seconds(42)), "test_frame");
79-
80-
// tf2::Stamped<Eigen::Affine3d> v1;
81-
// geometry_msgs::msg::PoseStamped p1;
82-
// tf2::convert(v, p1);
83-
// tf2::convert(p1, v1);
84-
85-
// EXPECT_EQ(v.translation(), v1.translation());
86-
// EXPECT_EQ(v.rotation(), v1.rotation());
87-
// EXPECT_EQ(v.frame_id_, v1.frame_id_);
88-
// EXPECT_EQ(v.stamp_, v1.stamp_);
89-
// }
81+
TEST(TfEigen, ConvertAffine3dStamped)
82+
{
83+
const Eigen::Affine3d v_nonstamped(Eigen::Translation3d(1, 2, 3) * Eigen::AngleAxis<double>(
84+
1, Eigen::Vector3d::UnitX()));
85+
const tf2::Stamped<Eigen::Affine3d> v(v_nonstamped, tf2::TimePoint(
86+
std::chrono::seconds(42)), "test_frame");
87+
88+
tf2::Stamped<Eigen::Affine3d> v1;
89+
geometry_msgs::msg::PoseStamped p1;
90+
tf2::convert(v, p1);
91+
tf2::convert(p1, v1);
92+
93+
EXPECT_EQ(v.translation(), v1.translation());
94+
EXPECT_EQ(v.rotation(), v1.rotation());
95+
EXPECT_EQ(v.frame_id_, v1.frame_id_);
96+
EXPECT_EQ(v.stamp_, v1.stamp_);
97+
}
9098

99+
// TODO(clalancette) Re-enable these tests once we have tf2/convert.h:convert(A, B) implemented
91100
// TEST(TfEigen, ConvertAffine3d)
92101
// {
93102
// const Eigen::Affine3d v(

0 commit comments

Comments
 (0)