Skip to content

Commit 6abb6b5

Browse files
committed
Enable Linters on Eigen, geometry_msgs and KDL
1 parent 171cfe0 commit 6abb6b5

File tree

6 files changed

+39
-2
lines changed

6 files changed

+39
-2
lines changed

tf2_eigen/CMakeLists.txt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,18 @@ install(DIRECTORY include/${PROJECT_NAME}/
2222

2323
if(BUILD_TESTING)
2424
find_package(ament_cmake_gtest REQUIRED)
25+
list(APPEND AMENT_LINT_AUTO_EXCLUDE
26+
ament_cmake_cppcheck
27+
ament_cmake_uncrustify
28+
ament_cmake_copyright
29+
)
30+
find_package(ament_lint_auto REQUIRED)
31+
find_package(ament_cmake_uncrustify REQUIRED)
32+
find_package(ament_cmake_cppcheck REQUIRED)
33+
ament_lint_auto_find_test_dependencies()
34+
ament_cppcheck(LANGUAGE "c++")
35+
ament_uncrustify(LANGUAGE "c++")
36+
2537
ament_add_gtest(tf2_eigen-test test/tf2_eigen-test.cpp)
2638
if(TARGET tf2_eigen-test)
2739
target_include_directories(tf2_eigen-test PUBLIC

tf2_eigen/package.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
<test_depend>ament_cmake_gtest</test_depend>
2424

2525
<build_export_depend>eigen</build_export_depend>
26+
<test_depend>ament_lint_auto</test_depend>
27+
<test_depend>ament_lint_common</test_depend>
2628

2729
<export>
2830
<build_type>ament_cmake</build_type>

tf2_geometry_msgs/CMakeLists.txt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,17 @@ ament_auto_find_build_dependencies(REQUIRED ${required_dependencies})
3030
if(BUILD_TESTING)
3131
find_package(ament_cmake_gtest REQUIRED)
3232
find_package(rclcpp REQUIRED)
33+
34+
find_package(ament_cmake_cppcheck REQUIRED)
35+
find_package(ament_cmake_cpplint REQUIRED)
36+
find_package(ament_cmake_lint_cmake REQUIRED)
37+
find_package(ament_cmake_uncrustify REQUIRED)
38+
39+
ament_cppcheck(LANGUAGE "c++")
40+
ament_cpplint()
41+
ament_lint_cmake()
42+
ament_uncrustify(LANGUAGE "c++")
43+
3344
ament_add_gtest(test_tf2_geometry_msgs test/test_tf2_geometry_msgs.cpp)
3445
if(TARGET test_tf2_geometry_msgs)
3546
target_include_directories(test_tf2_geometry_msgs PUBLIC include)

tf2_geometry_msgs/package.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@
2727
<exec_depend>tf2_ros_py</exec_depend>
2828

2929
<test_depend>ament_cmake_gtest</test_depend>
30+
<test_depend>ament_lint_auto</test_depend>
31+
<test_depend>ament_lint_common</test_depend>
3032
<test_depend>rclcpp</test_depend>
3133

3234
<export>

tf2_kdl/CMakeLists.txt

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ find_package(tf2 REQUIRED)
1818
find_package(tf2_ros REQUIRED)
1919

2020
ament_python_install_package(${PROJECT_NAME}
21-
PACKAGE_DIR src/${PROJECT_NAME})
21+
PACKAGE_DIR src/${PROJECT_NAME})
2222

2323
install(DIRECTORY include/${PROJECT_NAME}/
24-
DESTINATION include/${PROJECT_NAME}
24+
DESTINATION include/${PROJECT_NAME}
2525
)
2626

2727
# TODO(ahcorde): Port python once https://github.com/ros2/orocos_kinematics_dynamics/pull/4 is merged
@@ -34,6 +34,14 @@ if(BUILD_TESTING)
3434
find_package(rclcpp REQUIRED)
3535
find_package(tf2_msgs REQUIRED)
3636

37+
find_package(ament_cmake_cppcheck REQUIRED)
38+
find_package(ament_cmake_cpplint REQUIRED)
39+
find_package(ament_cmake_lint_cmake REQUIRED)
40+
find_package(ament_cmake_uncrustify REQUIRED)
41+
42+
ament_cppcheck(LANGUAGE "c++")
43+
ament_uncrustify(LANGUAGE "c++")
44+
3745
ament_add_gtest(test_kdl test/test_tf2_kdl.cpp)
3846
target_include_directories(test_kdl PUBLIC
3947
include

tf2_kdl/package.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
<exec_depend>tf2_ros_py</exec_depend>
2323

2424
<test_depend>ament_cmake_gtest</test_depend>
25+
<test_depend>ament_lint_auto</test_depend>
26+
<test_depend>ament_lint_common</test_depend>
2527
<test_depend>rclcpp</test_depend>
2628
<test_depend>tf2_msgs</test_depend>
2729

0 commit comments

Comments
 (0)